fix(meta-rules): exclude .gen.tsx from source-text scan; close 3 test gaps#42
Merged
Conversation
… gaps isScannableSource matched `.tsx` but its generated-file exclusion regex (`!/\.gen\.[cm]?ts$/u`) had no `x?`, so a generated `*.gen.tsx` was scanned by no-eslint-disable-comments / no-ts-suppressions and flagged for its own vendored banner. The regression test rigged itself around the gap (`ext === "tsx" ? "ts" : ext`); de-rig it so it bites. Also add regression tests for three verified-but-unguarded harness contracts surfaced by the subsystem sweep: - gate fallbackMessage(): 1200-char cap + eslint-JSON drop + truncation marker - lib/fs runArgvCommand(): missing binary -> exit 127, never a throw - inference wire: DeepSeek reasoning_content capture -> replay round-trip (and that it's omitted for non-DeepSeek providers) fallbackMessage is now exported for direct unit testing.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the isScannableSource helper to correctly ignore generated .tsx files, exports and adds unit tests for the fallbackMessage utility, adds tests for DeepSeek reasoning_content capturing and replaying, and introduces a test to ensure running a missing binary returns exit code 127 instead of throwing. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harness review sweep (all 12 subsystems)
Full adversarial
/harness-review allafter v0.18.4. 11 subsystems clean, 0 P1s. This PR lands the one ship-worthy code finding plus three missing-regression-test gaps.P2 (real, with masking test) —
isScannableSourceexcludes.gen.tsxsrc/meta-rules/rules/source-text/is-scannable.tsmatched.tsx(/\.[cm]?tsx?$/u) but its generated-file exclusion (!/\.gen\.[cm]?ts$/u) had nox?— so a generated*.gen.tsxwas scanned byno-eslint-disable-comments/no-ts-suppressionsand flagged for its own vendored eslint-disable/@ts-nocheckbanner.Latent (no
.gen.tsxproducer in-tree today), but the existing regression test rigged itself around the gap:isScannableSource(\src/routeTree.gen.${ext === "tsx" ? "ts" : ext}`)quietly substituted.gen.tsfor thetsx` case. De-rigged — reverting the source fix now fails the test (verified).!/\.gen\.[cm]?tsx?$/u+ doc comment*.gen.{ts,tsx,mts,cts}.P2 (missing regression tests for verified-but-unguarded contracts)
fallbackMessage()(src/validate/validate.ts) — 1200-char cap + eslint-JSON drop + truncation marker had zero coverage (the prior "vacuous cap test" suspicion). Now exported + unit-tested with >1200-char input.runArgvCommand()— missing binary → exit 127, never a throw (theBun.spawncatch path).reasoning_contentcapture→replay round-trip, and omission for non-DeepSeek providers.Verification
bun run validate: 1337 pass, 0 fail. Each new test confirmed to fail against the un-fixed code where applicable.Subsystems verified clean
loop/turn, tools, gate, oracles, browser, inference, render/CLI, mcp, web-scaffold, setup/conventions, lib/fs — all invariants checked against source + tests with repros.