fix(boringstack): extractFailures parses lint:meta i18n violations on .json locale files#150
Merged
Merged
Conversation
…n files (unblocks i18n park) build10 cleared every code wall (apps/api fully green) but parked at 1 on a single unused i18n key. Reproduced: extractFailures returned 0 signatures for that apps/ui output → opaqueGateError. Root: sourceFileFromLine matched only /\.[cm]?[jt]sx?$/, so a lint:meta violation whose file HEADER is a .json locale file (i18n-locale-keys-used reports common.json) never set currentFile → consumeLintMeta dropped it. Consequences: no structured error (opaque, unactionable) AND #61's completion-phase couldn't see rule=i18n-locale-keys-used, so WS-B reverted the model's wiring edits → trapped at 1. Fix: accept .json in sourceFileFromLine (a bare path-only line is unambiguous). Repro now yields 1 signature (rule=i18n-locale-keys-used); 49 extract-failures tests green (no mis-parse regression). Validating end-to-end via build11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #147. build10 trapped at 1 error because a standalone
i18n-locale-keys-usedviolation whose file header is a.jsonlocale file fell to opaqueGateError (sourceFileFromLine rejected .json + leading whitespace). Now parsed → structured error with rule set. Validated: build11 reached the i18n wall as an actionable error. Panel-approved; 49 tests.