Revert "Inbound Stuff + Email send (#196)"

[Huijiro]

This reverts commit af2468e.

Summary by CodeRabbit

Release Notes - v0.0.157

• Changes
  • Email sending capability has been removed and is currently unavailable in this release. Direct email sending through the system is no longer supported. Email reply functionality for responding to incoming messages remains fully supported and operational. Users should update their workflows accordingly if they depend on direct email sending features.

[coderabbitai]

Walkthrough

Version 0.0.157 removes email sending capability from the codebase. The send() method is removed from the EmailApi class, Email class, and EmailService interface, while email reply functionality is preserved. Package version is bumped and a test is updated to reflect API changes.

Changes

Cohort / File(s)	Summary
Documentation & versioning CHANGELOG.md, package.json	Changelog entry added for v0.0.157 documenting that email sending capability was removed; version bumped from 0.0.156 to 0.0.157.
Email API layer removal src/apis/email.ts	Removed public async send(agentId, email, authToken, messageId) method from EmailApi class; sendReply method preserved with existing tracing and error handling.
Email I/O layer removal src/io/email.ts	Removed public send(req, context, to, email, from) method from Email class including attachment handling and authorization checks; sendReply method preserved.
Type definitions src/types.ts	Removed send() method signature from EmailService interface; tightened VectorSearchParams generic type constraint from T = unknown to T extends JsonObject = JsonObject.
Test updates test/io/email.test.ts	Changed email.attachments from property access to method call email.attachments() with runtime validation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

The changes are cohesive in nature (consistent removal of send functionality across multiple layers) but span the API layer, I/O layer, types, and tests with interdependent modifications. Review requires verifying completeness of removal, consistency across all affected interfaces, and validation of the test adjustment.

Poem

🐰 A farewell to sending, that's quite a change!
No more emails dispatched to the range,
But replies still flourish, alive and well,
The attachments now answer to functions that tell,
Version 0.0.157 hops on its way! 📧✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "Revert 'Inbound Stuff + Email send (#196)'" is directly related to the main change in the changeset. The title clearly indicates this is a reversion operation that removes email sending functionality across multiple files (EmailApi, Email class, EmailService interface, and test files), which matches the stated objective of reverting commit af2468e. The title is specific and includes the reference to PR #196 and the original feature title, allowing a teammate reviewing the repository history to immediately understand that email sending capability is being removed.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch revert-email

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

CHANGELOG.md (1)

3-7: LGTM! Consider clarifying the timeline.

The changelog entry is clear and well-formatted. The phrase "unavailable at the moment" suggests this is a temporary removal. Consider adding a brief note about when or under what conditions the feature might be restored, if known, to set user expectations.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ecbe795 and adc4c2d.

⛔ Files ignored due to path filters (1)

• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (6)

• CHANGELOG.md (1 hunks)
• package.json (1 hunks)
• src/apis/email.ts (0 hunks)
• src/io/email.ts (0 hunks)
• src/types.ts (0 hunks)
• test/io/email.test.ts (2 hunks)

💤 Files with no reviewable changes (3)

• src/io/email.ts
• src/types.ts
• src/apis/email.ts

🧰 Additional context used

📓 Path-based instructions (2)

test/**

📄 CodeRabbit inference engine (AGENT.md)

Tests must mirror the source structure under the test/ directory

Files:

• test/io/email.test.ts

{src,test}/**/!(*.d).ts

📄 CodeRabbit inference engine (AGENT.md)

{src,test}/**/!(*.d).ts: Use strict TypeScript and prefer unknown over any
Use ESM import/export syntax; avoid CommonJS require/module.exports
Use relative imports for internal modules
Keep imports organized (sorted, no unused imports)
Use tabs with a visual width of 2 spaces
Limit lines to a maximum of 80 characters
Use single quotes for strings
Use proper Error types; do not throw strings
Prefer template literals over string concatenation

Files:

• test/io/email.test.ts

🧬 Code graph analysis (1)

test/io/email.test.ts (1)

src/router/data.ts (1)

• email (243-253)

🔇 Additional comments (2)

package.json (1)

3-3: LGTM!

The version bump from 0.0.156 to 0.0.157 is appropriate for this patch release and corresponds correctly to the changelog entry.

test/io/email.test.ts (1)

59-60: Email.attachments() method is correctly implemented and the test changes are accurate.

The verification confirms the Email class has the attachments() method at src/io/email.ts:374 with the signature attachments(): IncomingEmailAttachment[]. The test changes correctly update from property access to method calls and consistently use the expect(() => ...).not.toThrow() pattern before accessing the method result.