Repository navigation
Change cyan shade in light mode - #84
Conversation
WalkthroughUpdated light-mode hex color from #36EEE0 to #00AAAA across banner, logo, and text styling in tui/*. Dark-mode values remain #00FFFF. No logic, control flow, or public APIs changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
tui/text.go (1)
15-15: Optional: centralize brand cyan to avoid future driftDefine a single brand cyan and reuse across text, banner, and logo.
Apply this diff here:
- textStyleColor = lipgloss.AdaptiveColor{Light: "#00AAAA", Dark: "#00FFFF"} + textStyleColor = brandCyanAdd a small palette (new file) for reuse:
// tui/palette.go package tui import "github.com/charmbracelet/lipgloss" var brandCyan = lipgloss.AdaptiveColor{Light: "#00AAAA", Dark: "#00FFFF"}Then reference brandCyan in tui/banner.go and tui/logo.go as well (see suggested diffs in those files’ comments).
tui/logo.go (1)
30-30: Use shared brand cyanIf adopting a shared palette, switch to the common var.
- logoColor = lipgloss.AdaptiveColor{Light: "#00AAAA", Dark: "#00FFFF"} + logoColor = brandCyantui/banner.go (2)
10-10: Nit: spelling of “Foregroup”Variable name “bannerForegroupColor” likely intended “Foreground”. Consider renaming across the package in a follow-up for clarity.
12-12: Use shared brand cyanIf centralizing, reference the palette var.
- bannerTitleColor = lipgloss.AdaptiveColor{Light: "#00AAAA", Dark: "#00FFFF"} + bannerTitleColor = brandCyan
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
tui/banner.go(1 hunks)tui/logo.go(1 hunks)tui/text.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (4)
tui/text.go (2)
15-15: LGTM: light-mode brand cyan updated consistentlyChange looks correct and matches the PR goal.
15-15: No stale cyan hex codes found
- Verified that the old color
#36EEE0has been completely removed.- Confirmed new cyan
#00AAAAis now used in:
tui/text.go(line 15)tui/logo.go(line 30)tui/banner.go(line 12)tui/logo.go (1)
30-30: LGTM: logo light foreground updatedMatches the new light-mode cyan. No behavioral changes.
tui/banner.go (1)
12-12: LGTM: banner title light color updatedAligned with the new brand cyan; dark-mode unchanged.
Kind of a guess, everyone's terminal is different... some have opacity, etc. Went with what I thought is just best in general for contrast on a white background.
Summary by CodeRabbit