style(core): code style fix to avoid build failure#808
style(core): code style fix to avoid build failure#808xiaochen-zhou wants to merge 1 commit intoagentscope-ai:mainfrom
Conversation
Summary of ChangesHello @xiaochen-zhou, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses code style inconsistencies by reformatting specific lines in two Java files. The primary goal is to align the codebase with established style guidelines, which helps prevent build failures that can arise from strict formatting checks. This ensures code readability and maintainability without altering the functional logic. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
|
There was a problem hiding this comment.
Code Review
This pull request addresses a code style issue to prevent build failures, primarily by reformatting long lines. The changes are appropriate. I've added one suggestion to improve maintainability by replacing a hardcoded version string with its corresponding constant from Version.java. This will make future version updates easier.
| "agentscope-java", "AgentScope Java Framework", "1.0.10-SNAPSHOT"); | ||
| "agentscope-java", | ||
| "AgentScope Java Framework", | ||
| "1.0.10-SNAPSHOT"); |
There was a problem hiding this comment.
To improve maintainability and avoid having to update the version string in multiple places, it's better to use the io.agentscope.core.Version.VERSION constant. Note that the same hardcoded version string is used in the buildSync method on line 332 and should also be updated.
| "1.0.10-SNAPSHOT"); | |
| io.agentscope.core.Version.VERSION); |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
AgentScope-Java Version
[The version of AgentScope-Java you are working on, e.g. 1.0.9, check your pom.xml dependency version or run
mvn dependency:tree | grep agentscope-parent:pom(only mac/linux)]Description
code style fix to avoid build failure
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)