Skip to content

style(core): code style fix to avoid build failure#808

Open
xiaochen-zhou wants to merge 1 commit intoagentscope-ai:mainfrom
xiaochen-zhou:code-style
Open

style(core): code style fix to avoid build failure#808
xiaochen-zhou wants to merge 1 commit intoagentscope-ai:mainfrom
xiaochen-zhou:code-style

Conversation

@xiaochen-zhou
Copy link

AgentScope-Java Version

[The version of AgentScope-Java you are working on, e.g. 1.0.9, check your pom.xml dependency version or run mvn dependency:tree | grep agentscope-parent:pom(only mac/linux)]

Description

code style fix to avoid build failure

image

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@xiaochen-zhou xiaochen-zhou requested a review from a team February 18, 2026 02:37
@gemini-code-assist
Copy link

Summary of Changes

Hello @xiaochen-zhou, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses code style inconsistencies by reformatting specific lines in two Java files. The primary goal is to align the codebase with established style guidelines, which helps prevent build failures that can arise from strict formatting checks. This ensures code readability and maintainability without altering the functional logic.

Highlights

  • Code Style: Applied formatting changes to McpClientBuilder.java and VersionTest.java to ensure compliance with code style guidelines and prevent potential build failures.
Changelog
  • agentscope-core/src/main/java/io/agentscope/core/tool/mcp/McpClientBuilder.java
    • Reformatted a long line in the McpSchema.Implementation constructor for better readability.
  • agentscope-core/src/test/java/io/agentscope/core/VersionTest.java
    • Reformatted a long line in the Assertions.assertEquals call within testVersionConstant for improved code style.
Activity
  • The author has provided a checklist in the PR description, indicating items to be checked before review.
  • No other review comments or activity have been recorded yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@cla-assistant
Copy link

cla-assistant bot commented Feb 18, 2026

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Feb 18, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a code style issue to prevent build failures, primarily by reformatting long lines. The changes are appropriate. I've added one suggestion to improve maintainability by replacing a hardcoded version string with its corresponding constant from Version.java. This will make future version updates easier.

"agentscope-java", "AgentScope Java Framework", "1.0.10-SNAPSHOT");
"agentscope-java",
"AgentScope Java Framework",
"1.0.10-SNAPSHOT");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid having to update the version string in multiple places, it's better to use the io.agentscope.core.Version.VERSION constant. Note that the same hardcoded version string is used in the buildSync method on line 332 and should also be updated.

Suggested change
"1.0.10-SNAPSHOT");
io.agentscope.core.Version.VERSION);

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant