Repository navigation
Fix Fannkuch benchmark: thunk lazy let-bindings - #64
Merged
Merged
Conversation
- also remove test/untyped/scheme.agda
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The treeless pipeline happens to introduce some that are only sound under lazy semantics, e.g.
ToTreeless.updateCatchallhoists the body of a catch-all/overlapping clause above the pattern match.That's the reason Fannkuch benchmark failed on the Agda frontend: the recursive call was placed at the start before the pattern match and under strict evaluation loops forever.
A more proper solution would be to emit actual tLazy/tForce λ-box terms, but this seems to break things downstream in Peregrine and its backends, so leave a proper lazy-evaluation solution for the future, and now settle for this naive call-by-name fix.
| tLazy t => EAst.tLambda nAnon (lift 1 0 (implement_lazy_force t)) | tForce t => EAst.tApp (implement_lazy_force t) tBox.