Repository navigation
Conversation
Collaborator
|
For what it's worth, that's what we're also doing in agda2train. |
Collaborator
Author
|
Ah nice, then let's do that. Although I think we can also only do that for names that have been Agda-generated (with, \where, etc) and keep the others. Let's try and see if this breaks things. I noticed the only \where functions that are inlined are the non-recursive one, whereas we decided to never compile them, so I'm working on fixing that. |
flupe
marked this pull request as draft
February 25, 2026 13:12
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The easy fix is to suffix all names with the (unique) name id.
Will do more tests to see if this also solves the problem with where clauses.
However, this means we give up on (approximate) 1:1 name correspondence.
I'm willing to lose this if this means we ensure compilation is correct, and with the custom re-mapping feature this probably isn't too bad, but idk.