Add shared materials across layers#36
Open
Gerard-Taulats wants to merge 1 commit into
Open
Conversation
Adds support to declare materials in the YAML presets and point each layer to a named material, or custom for it. Signed-off-by: Gerard-Taulats <295358376+Gerard-Taulats@users.noreply.github.com>
Gerard-Taulats
force-pushed
the
Gerard-Taulats-shared-material
branch
from
cab6cfe to
44325ce
Compare
dnltz
requested changes
Jun 24, 2026
dnltz
left a comment
dnltz
left a comment
Contributor
There was a problem hiding this comment.
There is a JSON validation schema at scripts/internal/color-schema.schema.json and it would fail as soon as someone adds those. How about updating import_gdsii/configs/colors/ihp-sg13g2/realistic.yaml to use this feature and extending the color schema? You can just ask Claude to update the schema according to the YAML file.
|
|
||
| # Apply material | ||
| mat = create_material(f"Mat_{name}", color) | ||
| mat_name = color.get("mat_name", f"Mat_{name}") |
Contributor
There was a problem hiding this comment.
Should we call this Color_ instead of Mat_ since it's not a material anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support to declare materials in the YAML presets and point each layer to a named material, or custom for it.
In the YAML file, add a new field "materials", then inside of it the material name, and then the material description like currently used per layer.
To assign a material to a layer, just write the material name.
For example: