Avoid regex in fnmatch crate - #191
Conversation
33a2087 to
ecac8b8
Compare
|
Clippy complains about code I did not touch ._. please ignore it. |
703e701 to
c943499
Compare
|
Rebased. spellcheck yells at me because I named a variable |
136f930 to
261d403
Compare
261d403 to
d9402b8
Compare
d9402b8 to
03d9ce9
Compare
|
|
|
@livingsilver94 Is this something you feel like working on with us in alpha2...? |
cb3d6bf to
15d2059
Compare
|
I think this PR is quite ready but I want to ensure it didn't break moss at runtime. Can you think of a manual test plan? |
Rebase it on main and run with it in prod on your own system for a week or two yourself first? |
fba9b85 to
3d47ddf
Compare
3d47ddf to
5bb8c0f
Compare
53ce75e to
a60c561
Compare
a60c561 to
9d51fcb
Compare
|
Just a rebase. |
Rewrite the fnmatch crate to not use regex. It's fast (comparable to the wildmatch crate), tested and fuzzed. Should be usable already. Run
cargo benchto compare it against wildmatch and regex.Documentation is in code an in the crate-level README.md file. Launch
cargo doc --open --no-deps --document-private-itemsfor a decent layout.