Skip to content

Avoid regex in fnmatch crate - #191

Open
livingsilver94 wants to merge 2 commits into
mainfrom
fnmatch-simplify
Open

Avoid regex in fnmatch crate#191
livingsilver94 wants to merge 2 commits into
mainfrom
fnmatch-simplify

Conversation

@livingsilver94

@livingsilver94 livingsilver94 commented Mar 26, 2024

Copy link
Copy Markdown
Member

Rewrite the fnmatch crate to not use regex. It's fast (comparable to the wildmatch crate), tested and fuzzed. Should be usable already. Run cargo bench to compare it against wildmatch and regex.

Documentation is in code an in the crate-level README.md file. Launch cargo doc --open --no-deps --document-private-items for a decent layout.

@livingsilver94

Copy link
Copy Markdown
Member Author

Clippy complains about code I did not touch ._. please ignore it.

@ermo ermo added the type: enhancement (PR) New feature delivered as a PR label Apr 16, 2024
@livingsilver94
livingsilver94 force-pushed the fnmatch-simplify branch 2 times, most recently from 703e701 to c943499 Compare May 10, 2024 17:16
@livingsilver94

Copy link
Copy Markdown
Member Author

Rebased. spellcheck yells at me because I named a variable matc :|

@livingsilver94
livingsilver94 marked this pull request as draft July 26, 2024 10:59
@livingsilver94
livingsilver94 marked this pull request as ready for review July 26, 2024 11:18
@CLAassistant

CLAassistant commented Jan 17, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ermo

ermo commented May 8, 2025

Copy link
Copy Markdown
Member

@livingsilver94 Is this something you feel like working on with us in alpha2...?

@ermo
ermo marked this pull request as draft May 9, 2025 13:44
@livingsilver94
livingsilver94 force-pushed the fnmatch-simplify branch 4 times, most recently from cb3d6bf to 15d2059 Compare August 11, 2026 09:21
@livingsilver94

Copy link
Copy Markdown
Member Author

I think this PR is quite ready but I want to ensure it didn't break moss at runtime. Can you think of a manual test plan?

@ermo

ermo commented Aug 11, 2026

Copy link
Copy Markdown
Member

I think this PR is quite ready but I want to ensure it didn't break moss at runtime. Can you think of a manual test plan?

Rebase it on main and run with it in prod on your own system for a week or two yourself first?

@livingsilver94
livingsilver94 force-pushed the fnmatch-simplify branch 4 times, most recently from fba9b85 to 3d47ddf Compare August 18, 2026 13:48
@livingsilver94
livingsilver94 force-pushed the fnmatch-simplify branch 5 times, most recently from 53ce75e to a60c561 Compare August 19, 2026 14:07
@livingsilver94
livingsilver94 marked this pull request as ready for review August 19, 2026 17:25
@livingsilver94 livingsilver94 added the type: performance Will make things faster/leaner label Aug 19, 2026
@livingsilver94
livingsilver94 removed the request for review from ikeycode August 19, 2026 22:11
@livingsilver94

Copy link
Copy Markdown
Member Author

Just a rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement (PR) New feature delivered as a PR type: performance Will make things faster/leaner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants