Repository navigation
fix dashboard auth rows for new harnesses - #975
Merged
aaronjmars merged 1 commit intoAug 27, 2026
Merged
Conversation
Collaborator
|
Merging this - correct, tested, and green. One follow-up nit (not a blocker, predates this PR): the |
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the Cursor, Hermes, and GLM credentials permanent first-class rows in Settings → Access Keys, and give Hermes the same Connect/Reconnect behavior as the existing captured-login harnesses.
Why
PR #967 added all three harnesses to installation, resolution, execution, and the top-bar picker, but their credentials were not added to the dashboard builtin catalog. A secret appeared only after it had already been set, as a generic custom Skill Keys row; an unset credential disappeared entirely. HERMES_AUTH also was not mapped to its native OAuth flow, so its set row offered Remove but no Reconnect.
Fix
Verification
Mutation checks:
keeps every new harness credential visible even before it is setfailed with actualundefined, expectedCore.maps every captured login secret to its Connect/Reconnect flowfailed because HERMES_AUTH was absent.