Repository navigation
feat(onchain-monitor): add reorg-safe evidence replay - #1251
sentinelhood wants to merge 5 commits into
Conversation
From aaronjmars: - Split any 10k-log window, wallets included (v4 PoolManager returns ~29.7k logs in one 30k-block window: 3 splits, 7 calls). - ERC-721 Transfer shares topic0 with ERC-20: 3 topics = erc20, 4 topics = erc721 (empty data, token id in topics[3]); never call decimals() on erc721. - docs/community-skill-packs.md: Sentinel Pack row no longer claims onchain-monitor lacks Robinhood Chain. From Svector-anu: - Clamp a late robinhood run to 280k blocks (~8h) and log the skipped span; 12h late was ~420k blocks, 15 windows per direction per watch. - Path C gets the same WebFetch retry as Paths A/B on a non-429 failure.
aaronjmars
left a comment
There was a problem hiding this comment.
nice follow-up. the #1244 review fixes (8h clamp, erc-721 split, log-limit halving) are good.
2 things before merge:
- reorg replay says to drop
alerted_txhashes first seen inside the replay range, butalerted_txonly stores hashes, no block. the agent can't do that. store{hash, block}or drop that line. - the evidence receipt has one
chain/chain_id/block_hash, but one run covers every watch across chains. needs one entry per chain (or one receipt per chain).
nit: memory/evidence/ gets a new file every run, forever. add a prune (keep 30 days?).
# Conflicts: # docs/community-skill-packs.md
|
Addressed the review points in commit
Validation: skill security scan, category check, evidence JSON example parse, and |
Svector-anu
left a comment
There was a problem hiding this comment.
ran the full local checklist against this branch: check-skill-categories, check-capabilities-parity, validate-config.js, validate-readme-catalog.mjs, generate-skills-json (ci's normalized diff), generate-skill-icons --check, lint-shell.sh, biome ci ., dashboard typecheck. all pass. eyebrowlock.json diff is just this skill's own hash updating, as expected for a skill.md change.
read through the reorg logic, the evidence receipt schema, and the erc-20/erc-721 disambiguation by topic count. internally consistent, atomic state writes, evidence explicitly scoped as an audit trail not a safety verdict. solid follow-up to #1244.
approving.
Follow-up to #1244.
Adds replayable evidence receipts and reorg-aware monitoring:
Validation:
The repository-wide eyebrowlock baseline drift is not asserted by this PR.
Need help on this PR? Tag
@codesmith-botwith what you need.