Repository navigation
test(dev-loop): stop a pipefail flake in the dispatch-budget check - #1245
Merged
Merged
Conversation
…fail flake The dev-loop block in aeon.yml is about 4.8 KB, over sed's 4 KB pipe buffer, so sed writes it in two chunks. When grep -q matches on the first chunk it exits, sed's second write hits a broken pipe, and under set -o pipefail the check fails at random (seen on aeon#1244 run 39135349362: sed couldn't flush stdout, then 'dev-loop dispatch budget is not five'). Capture the block first, then grep a here-string, in both dev-loop tests.
…er comment The step 0 block in idea-pipeline is over 4 KB, so the sed | grep -q pipe under pipefail could turn its negative check into a silent pass. Capture both blocks first, fail if a block is missing, then grep a here-string. Also reword the comment in the dev-loop proof and repair tests: the 4 KB limit is sed's own stdout buffer, not the pipe buffer. Co-Authored-By: Claude <noreply@anthropic.com>
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
test_dev_loop_proof.shandtest_dev_loop_repair.shpiped thedev-loop:block ofaeon.ymlfromsedintogrep -Fq. The block is about 4.8 KB, oversed's 4 KB pipe buffer, sosedwrites it in two chunks. Whengrep -qmatches on the first chunk it exits,sed's second write hits a broken pipe, and underset -o pipefailthe check fails at random.Seen on #1244 (run 39135349362, lane 6):
A rerun of the same commit passed.
Fix
Capture the block into a variable first, then grep a here-string, like the
checkout_block/commit_blockchecks above it already do. Same check, no pipe.Checked
shellcheck -S warningis clean on both files.Need help on this PR? Tag
@codesmith-botwith what you need.