Conversation
- Replace Authorization Code Flow with PKCE (no client_secret needed) - Hardcode default client_id in AppConfig, remove setup guide screen - Add custom Client ID option in Settings > Advanced Options and Login screen - Unify all auth/token/playback code via effectiveSpotifyClientIdProvider - TokenRefreshService rebuilds when client_id changes - Add l10n keys for zh/en/ja - Add iOS screenshot, update READMEs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client_secretrequirement entirely. Defaultclient_idhardcoded inAppConfig, setup guide screen removed for zero-config onboarding.effectiveSpotifyClientIdProvider.client_idchanges, tracked via_lastTokenRefreshClientId.Changes
AppConfig: added defaultspotifyClientIdOAuthService: PKCE flow withcode_verifier/code_challengeAuthRepositoryImpl/TokenRefreshService: acceptclientIdparameter instead of readingAppConfigdirectlyCredentialsLocalDataSource: addedgetCustomSpotifyClientId()/saveCustomSpotifyClientId()/clearCustomSpotifyClientId()CredentialsProvider: addedcustomSpotifyClientIdstate +effectiveSpotifyClientIdProviderFocusSessionProvider/PlaybackProvider: replacedAppConfig.spotifyClientIdwitheffectiveSpotifyClientIdProviderLoginScreen: added Advanced Options section for pre-login Client ID configurationApiCredentialsSection: added collapsible Advanced Options with save/clear + re-auth promptsetup_guide_screen.dart, updated READMEs, added iOS screenshotTest plan