Repository navigation
chore(deps): resolve Snyk findings in web and website - #37
Open
adrijshikhar wants to merge 2 commits into
Open
adrijshikhar wants to merge 2 commits into
adrijshikhar wants to merge 2 commits into
Conversation
Resolves Snyk findings in esbuild 0.21.5 (critical), vitest 2.1.9 (critical), @vitest/mocker 2.1.9 (high) and vite 5.4.21 (high, medium). No config or test changes were required.
Bumps astro to 7.3.5 and devalue to 5.9.4 (fixes SNYK-JS-DEVALUE-20044498), and drops the hoisted vite 6.4.3 / esbuild 0.25.12 in favour of vite 8.3.1.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the Snyk open-source findings in
web/andwebsite/. The Go module was already clean and is not changed.Changes
vitevitest@vitest/mocker5.0.2@vitejs/plugin-reactvite ^8)astrobun update)devaluevite(hoisted, via@tailwindcss/vite)@tailwindcss/vite,tailwindcss,typescriptbun update, no new majorsNo source, config or test changes were needed.
vite.config.ts(with the inlinetestblock) works unchanged on vite 8 / vitest 5.Snyk results (
snyk test --all-projects --dev)The 'Before' column is the original report. A baseline re-run on
origin/mainfor this PR found 8 (2 critical, 5 high, 1 medium) because it didn't flag website's esbuild 0.25.12. esbuild 0.25.12 no longer appears inwebsite/bun.lockeither way.Fixed: esbuild 0.21.5 (critical), vitest 2.1.9 (critical), esbuild 0.25.12 via website vite 6.4.3, @vitest/mocker 2.1.9 (high), vite 5.4.21 (high + medium), devalue 5.9.2 (high).
bun auditalso reports nothing in either subproject (it found 7 inwebbefore).Remaining findings
http-cache-semantics@4.2.0(viaastro)http-cache-semantics@4.2.0(viaastro)Both are only in the build-time static marketing site and nothing ships them to users. Revisit when upstream releases a fix or astro drops the dependency.
Notes
^20.19 / >=22.12.jsdom@30already required Node>=22.22, so this doesn't raise the floor.vite buildwas already there before this change.bun run checkinwebsite/asks to install@astrojs/check. That dependency was never added, and CI doesn't run the check.Test plan
web:rm -rf node_modules && bun install --frozen-lockfileweb:bun run build(tsc -b + vite build)web:bun run test, 19 files / 157 tests passweb:bun run format:checkwebsite:rm -rf node_modules && bun install --frozen-lockfilewebsite:bun run build, 13 pagesmake uiandgo test -race ./...passbun auditin both subprojectsbun run devinweb/against a running backend. Check the/apiproxy, the event list and the chartsbun run previewinwebsite/and click through the landing page and/docs