Repository navigation
ci: decouple release-please and publish workflows - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Separates the combined release workflow into two independent workflows:
.github/workflows/release-please.yml: Runs only onpush: branches: [main], executes release-please to open/update release PRs and tag releases when PRs are merged. Scoped to concurrencyrelease-please-${{ github.ref }}. It never halts or pauses for environment review, ensuring releases and PR merges onmainare never blocked..github/workflows/publish.yml: Runs only onpush: tags: ['v*.*.*'](orworkflow_dispatch), runs pre-release test verification (make ui,go test -race ./..., web tests), builds with GoReleaser, verifies release tarballs and CLI version probe, and handles gated Homebrew tap & Docker distribution underenvironment: release. Scoped to concurrencypublish-${{ github.ref }}.Motivation & Fix
Previously,
release.ymlhad top-level concurrencygroup: release-${{ github.ref }}withcancel-in-progress: false. When a release was cut and reachedpublish-homebrew/publish-docker(which requires manual approval underenvironment: release), GitHub Actions held the lock onmainindefinitely until approved or timed out. Any subsequent PR merged tomainqueued behind this lock, completely blocking Release Please from opening/updating patch PRs.Separating into two workflows eliminates this deadlock entirely.
Verification
go test -race ./...(335 passed across 22 packages)