Remove interval property from Credential Offer #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IngridPuppet
approved these changes
Jun 10, 2025
Closes keycloak#39294 Signed-off-by: forkimenjeckayang <[email protected]>
forkimenjeckayang
force-pushed
the
issue-39294
branch
from
0258bd5 to
01af265
Compare
IngridPuppet
force-pushed
the
main
branch
2 times, most recently
from
bda0e2a to
f99c912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the recent specification change in OpenID for Verifiable Credential Issuance (OID4VCI), where the interval property was moved from the Credential Offer to the Deferred Credential Response.
To align with the updated specification, this change removes the interval property from the
PreAuthorizedCodemodel, which is part of theCredential Offerpayload.Changes:
equals()andhashCode()methods in PreAuthorizedCode.java to reflect the removal of the interval property.Closes keycloak#39294
Closes #43