Repository navigation
switch version parsing to use standard commands - #4347
Merged
Merged
Conversation
Signed-off-by: Stewart X Addison <sxa@ibm.com>
github-actions
Bot
added
compatibility
karianna
reviewed
Dec 23, 2025
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
karianna
approved these changes
Dec 25, 2025
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
karianna
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grep -Eois not standard grep syntax and is incompatible with Solaris producing errors when this is run. The incompatible code was introduced in #4304.Change to using
awkas it avoids the fork of additional processes to parse the files and is standard across UNIX-based systems.@judovana has suggested using a simpler
grepconstruct but personally I'm losing interest in testing things on this platform at the moment but happy if someone wishes to propose and test an alternative ;-)