Skip to content

chore: deps updates - #158

Draft
marissahuysentruyt wants to merge 2 commits into
mainfrom
update-deps
Draft

marissahuysentruyt wants to merge 2 commits into
mainfrom
update-deps

Conversation

@marissahuysentruyt

@marissahuysentruyt marissahuysentruyt commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Updates some of our dependencies. I purposely have not udpated the eslint or typescript because they conflict with the AEM CLI update.

⚠️ Known accessibility bug: The accessibility fixture tests for the se-input and se-textarea are failing because of the contrast between the updated background color (added in #167 as a hotfix for the Safari issue mentioned there)

Screenshots (if applicable)

Type of change

  • Bug fix
  • New feature / block
  • Refactor
  • Docs / content
  • Chore (deps, config, tooling)

Related issue(s)

Validation steps

  • This PR has visual elements, so it was reviewed by a designer.
  • This PR has code changes, and our linters still pass.
  • This PR affects production code, so it was browser tested (see below).
  • This PR affects existing pages, so automated E2E tests were run (see below).
  • This PR has new code, so new tests were added or updated, and they pass.
  • This PR has copy changes, so copy was proofread and approved.
  • The content of this PR requires documentation, so a detailed description of the component's purpose, requirements, quirks, and instructions for use by designers and developers was added, along with accessibility information if pertinent.

To Validate

URL for testing:
https://update-deps--spectrum-hub--adobe.aem.live/

  • Make sure all PR Checks have passed
  • Pull down the branch locally or visit the branch preview
  • Run npm test and confirm all tests pass
  • Run npm run lint and confirm no linting errors
  • Verified in browser with aem up

Accessibility testing checklist

  • Keyboard
  1. Go here
  2. Do this action
  3. Expect this result
  • Screen reader
  1. Go here
  2. Do this action
  3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aem-code-sync

aem-code-sync Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run all PSI checks
  • Re-run failed PSI checks
  • Re-sync branch
Commits

@aem-code-sync

aem-code-sync Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@marissahuysentruyt

Copy link
Copy Markdown
Collaborator Author

/talos

Comment thread package.json
"@adobe/aem-cli": "^16.20.9",
"@adobe/eslint-config-helix": "^3.0.17",
"@axe-core/playwright": "^4.11.3",
"@adobe/aem-cli": "16.21.8",

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the jump to 22 upgrades isomorphic-git, which seems to be blocking playwright.

This branch was successfully deployed

1 active deployment
update-deps — 1c74b63a Deployed Oct 8, 2026 by aem-code-sync[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant