Skip to content

Vrt - #143

Draft
marissahuysentruyt wants to merge 9 commits into
mainfrom
vrt
Draft

Vrt#143
marissahuysentruyt wants to merge 9 commits into
mainfrom
vrt

Conversation

@marissahuysentruyt

@marissahuysentruyt marissahuysentruyt commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Screenshots (if applicable)

Type of change

  • Bug fix
  • New feature / block
  • Refactor
  • Docs / content
  • Chore (deps, config, tooling)

Related issue(s)

  • fixes [Issue Number]

Validation steps

  • This PR has visual elements, so it was reviewed by a designer.
  • This PR has code changes, and our linters still pass.
  • This PR affects production code, so it was browser tested (see below).
  • This PR affects existing pages, so automated E2E tests were run (see below).
  • This PR has new code, so new tests were added or updated, and they pass.
  • This PR has copy changes, so copy was proofread and approved.
  • The content of this PR requires documentation, so a detailed description of the component's purpose, requirements, quirks, and instructions for use by designers and developers was added, along with accessibility information if pertinent.

To Validate

URL for testing:
https://vrt--spectrum-hub--adobe.aem.live/

  • Make sure all PR Checks have passed
  • Pull down the branch locally or visit the branch preview
  • Run npm test and confirm all tests pass
  • Run npm run lint and confirm no linting errors
  • Verified in browser with aem up

Accessibility testing checklist

  • Keyboard
  1. Go here
  2. Do this action
  3. Expect this result
  • Screen reader
  1. Go here
  2. Do this action
  3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aem-code-sync

aem-code-sync Bot commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run all PSI checks
  • Re-run failed PSI checks
  • Re-sync branch
Commits

@aem-code-sync

aem-code-sync Bot commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Page Scores Audits Google
📱 / Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI
🖥️ / Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI

@marissahuysentruyt marissahuysentruyt added 🚧 WIP Work in progress, don't judge ❌ Do not merge This is not for merging. 🧪 Testing Adding tests, fixing tests, changing tests, all the testing related things labels Sep 24, 2026
marissahuysentruyt and others added 9 commits October 19, 2026 17:17
@marissahuysentruyt
test(visual): add Playwright regression coverage
89ab681 
- reuse deterministic accessibility fixtures across desktop and mobile themes

- enforce fixture coverage and add representative page smoke states

- add non-blocking comparison and manual baseline workflows

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@marissahuysentruyt
test(visual): reconcile current fixture coverage
1a52b0e 
- cover the columns grid fixture introduced on the updated base

- keep shared fixture navigation in merged accessibility specs

- exclude Node-only visual tests from Web Test Runner

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@marissahuysentruyt
fix(statustable): fix bad import afte rebase
fdf8a73
@marissahuysentruyt
fix(vrt): missing sitenav-search and remove schedule exception
2b0aa60
@marissahuysentruyt
feat(vrts): baselines
b1b172d
@marissahuysentruyt
feat(vrt): testing deployed versions
3841078
@marissahuysentruyt
chore: pattern library page baselines
8153a83
@marissahuysentruyt
test(vrt): stabilize deployed pattern page baselines
8f9e9ab 
- wait for section, stylesheet, component, image, font, and iframe readiness
- freeze scroll-reactive page chrome during full-page screenshot stitching
- isolate proven volatile RSP previews and remove local macOS baselines
- document the deployed pattern-library capture contract

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@marissahuysentruyt
feat(vrt): add browser-based regression review
86ce3c4 
- keep Playwright as the comparison engine while exposing expected, actual,
and diff images through its browser UI
- require targeted Linux baseline updates and reject options that could
bypass suite isolation or snapshot safeguards
- document approval, rejection, deployed preview, and CI fallback workflows

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

This branch was successfully deployed

1 active deployment
vrt — 86ce3c4e Deployed Oct 19, 2026 by aem-code-sync[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

❌ Do not merge This is not for merging. 🧪 Testing Adding tests, fixing tests, changing tests, all the testing related things 🚧 WIP Work in progress, don't judge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@marissahuysentruyt