Repository navigation
chore(core): document clamp_radius and assert the button-ios radius token is bound - #1591
Merged
Merged
Conversation
…oken is bound Restore the rounded_path doc line, give clamp_radius its own doc, and make the cli_platform test check radius == min(token value, height / 2).
|
Contributor
🎨 Token Changes ReportTokens Changed (0)Original Branch: This comment was automatically generated by the token diff tool. 🤖 |
Contributor
🧩 Component Schema Changes ReportNo component schema changes detected.This comment was automatically generated by the component schema diff tool. 🤖 |
Contributor
Run report for f6ac622eTotal time: 4m 45s | Comparison time: 6m 54s | Estimated savings: 2m 8s (31.0% faster)
Changed files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-ups to #1590 (comment and test only):
Closed outline of a rect with independent corner radii [tl, tr, br, bl].doc line aboverounded_pathinsdk/core/src/visual.rs. fix(core): clamp the corner radius to half the box so an oversized radius draws a pill #1590 insertedclamp_radiusbetween that line and its function.clamp_radiusits own doc: a corner radius cannot exceed half the box's width or height, like CSSborder-radius.cli_platform.rsassertion forrender button --platform ios. It now checks that the scene binds thebutton-md-radius-capsuletoken (value 20px) and that the container radius equalsmin(token value, height / 2), which is 17.1 for m. Before, it only checkedradius == height / 2, which would also pass if the token were not bound.No behavior change.
Related Issue
Follow-up to #1590 (p6ga.8.59), found in review.
Motivation and Context
A wrong doc placement and an assertion that did not prove the radius token is bound.
How Has This Been Tested?
cargo test -p design-data-cli --test cli_platformpasses (29 tests).cargo fmt --check,cargo clippy --all-targets -- -D warnings,moon run sdk:test sdk-wasm:test design-data:validate design-data:validate-dataset tokens:verifyLegacyOutput root:validate-platform-recipes root:test-platform-recipes-guard root:test-platform-recipes-e2e --force(1,738 Rust tests and 126 WASM tests pass), the changeset linter with--fail-on-warnings,check-ci-coverageandai:check, all passing.pnpm-lock.yamlis unchanged;cargo check --all-targetspasses.Screenshots (if appropriate):
N/A
Types of changes
Checklist: