Repository navigation
feat(cli): opt-in consumer-smoke workflow for platform eject - #1547
Merged
Merged
Conversation
Contributor
🎨 Token Changes ReportTokens Changed (0)Original Branch: This comment was automatically generated by the token diff tool. 🤖 |
Contributor
Run report for 7bc05d78Total time: 1m 50s | Comparison time: 3m 8s | Estimated savings: 1m 18s (41.4% faster)
Changed files |
Contributor
🧩 Component Schema Changes ReportNo component schema changes detected.This comment was automatically generated by the component schema diff tool. 🤖 |
🦋 Changeset detectedLatest commit: 7bc05d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Adds --with-consumer-smoke, which scaffolds consumer-smoke.yml running the repo's own consumer/smoke.sh. The validate action gains install-only and picks the release binary by runner OS/arch. Closes h890.7.3 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…d features Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
GarthDB
force-pushed
the
feat/consumer-smoke-eject
branch
from
October 20, 2026 17:28
eafd397 to
7bc05d7
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an opt-in consumer-codegen smoke workflow for platform-manifest repos.
design-data platform eject <id> --with-consumer-smokealso writes.github/workflows/consumer-smoke.yml. It runs on PRs touching the manifest, extensions, config orconsumer/, plus manual dispatch. It installs the CLI, then runs the repo's ownconsumer/smoke.sh(skips with a notice if absent)..github/actions/validate: newinstall-onlyinput, and the release install now picks the binary by runner OS/arch (newcli-asset-name.sh+ test).docs/MIGRATION.mddocuments the flag and thesmoke.shcontract.The scaffold is language-agnostic: the repo's script owns codegen and the build, so no UUIDs or Swift/python assumptions live here. iOS is not the target: the iOS manifest is now incubated at
platforms/iosand the externalspectrum-ios-design-datarepo is consumer-only with its ownconsumer/smoke.shand macOS workflow (pinned to a monorepo commit, CLI built from source). This generalizes that pattern for other ejected platform repos.Related Issue
Closes h890.7.3 (bead; DNA-1741).
Motivation and Context
Codegen breakage in platform consumers (WS4) went undetected in CI. A generic hook avoids building something brittle around the unstable iOS PoC.
How Has This Been Tested?
moon run sdk:fmt: passedmoon run sdk:lint: passedmoon run sdk:test: passed (1565 run, 1565 passed, 2 skipped), including the newplatform_eject_with_consumer_smoke_writes_workflowand the extended eject test, which parse the emitted YAMLbash .github/actions/validate/scripts/cli-asset-name.test.sh: passednode tools/changeset-linter/src/cli.js check --fail-on-warnings: passedNot run: the generated workflow on a live runner (no consumer repo with
smoke.shyet).Screenshots (if appropriate):
N/A
Types of changes
Checklist: