Skip to content

feat(cli): opt-in consumer-smoke workflow for platform eject - #1547

Merged
GarthDB merged 2 commits into
mainfrom
feat/consumer-smoke-eject
Oct 20, 2026
Merged

GarthDB merged 2 commits into
mainfrom
feat/consumer-smoke-eject

Conversation

@GarthDB

@GarthDB GarthDB commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Description

Adds an opt-in consumer-codegen smoke workflow for platform-manifest repos.

  • design-data platform eject <id> --with-consumer-smoke also writes .github/workflows/consumer-smoke.yml. It runs on PRs touching the manifest, extensions, config or consumer/, plus manual dispatch. It installs the CLI, then runs the repo's own consumer/smoke.sh (skips with a notice if absent).
  • .github/actions/validate: new install-only input, and the release install now picks the binary by runner OS/arch (new cli-asset-name.sh + test).
  • docs/MIGRATION.md documents the flag and the smoke.sh contract.

The scaffold is language-agnostic: the repo's script owns codegen and the build, so no UUIDs or Swift/python assumptions live here. iOS is not the target: the iOS manifest is now incubated at platforms/ios and the external spectrum-ios-design-data repo is consumer-only with its own consumer/smoke.sh and macOS workflow (pinned to a monorepo commit, CLI built from source). This generalizes that pattern for other ejected platform repos.

Related Issue

Closes h890.7.3 (bead; DNA-1741).

Motivation and Context

Codegen breakage in platform consumers (WS4) went undetected in CI. A generic hook avoids building something brittle around the unstable iOS PoC.

How Has This Been Tested?

  • moon run sdk:fmt: passed
  • moon run sdk:lint: passed
  • moon run sdk:test: passed (1565 run, 1565 passed, 2 skipped), including the new platform_eject_with_consumer_smoke_writes_workflow and the extended eject test, which parse the emitted YAML
  • bash .github/actions/validate/scripts/cli-asset-name.test.sh: passed
  • node tools/changeset-linter/src/cli.js check --fail-on-warnings: passed

Not run: the generated workflow on a live runner (no consumer repo with smoke.sh yet).

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions

Copy link
Copy Markdown
Contributor

🎨 Token Changes Report

Tokens Changed (0)

Original Branch: main


This comment was automatically generated by the token diff tool. 🤖

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Run report for 7bc05d78

Total time: 1m 50s | Comparison time: 3m 8s | Estimated savings: 1m 18s (41.4% faster)

Action Time Status Info
⬛️ SetupProto(0.57.4) 0ms Skipped
🟩 SyncWorkspace 7.2ms Passed
🟩 SyncProject(sdk) 0.4ms Passed
⬛️ SetupToolchain(node:20.17.0) 497.1ms Skipped
⬛️ SetupToolchain(rust:1.88.0) 850.6ms Skipped
🟩 SetupEnvironment(rust, sdk) 60.3ms Passed
⬛️ InstallDependencies(rust, sdk) 6ms Skipped
⬛️ SetupToolchain(pnpm:10.17.1) 636ms Skipped
⬛️ SetupToolchain(javascript) 0ms Skipped
⬛️ SetupEnvironment(javascript, sdk) 0.5ms Skipped
🟩 RunTask(sdk:fmt-check) 533ms Passed
🟩 InstallDependencies(javascript, sdk) 4.3s Passed
🟩 RunTask(sdk:codegen-check) 123.9ms Passed
🟩 RunTask(sdk:lint) 36.2s Passed
🟩 RunTask(sdk:test-doc) 1m 12s Passed
🟩 RunTask(sdk:test) 1m 45s Passed
Changed files
.changeset/consumer-smoke-eject.md
.github/actions/validate/README.md
.github/actions/validate/action.yml
.github/actions/validate/scripts/cli-asset-name.sh
.github/actions/validate/scripts/cli-asset-name.test.sh
docs/MIGRATION.md
sdk/Cargo.lock
sdk/cli/Cargo.toml
sdk/cli/src/main.rs
sdk/cli/tests/cli_platform.rs

@github-actions

Copy link
Copy Markdown
Contributor

🧩 Component Schema Changes Report

No component schema changes detected.

This comment was automatically generated by the component schema diff tool. 🤖

@changeset-bot

changeset-bot Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7bc05d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adobe/design-data-tui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

test and others added 2 commits October 20, 2026 11:27
Adds --with-consumer-smoke, which scaffolds consumer-smoke.yml running the
repo's own consumer/smoke.sh. The validate action gains install-only and
picks the release binary by runner OS/arch.

Closes h890.7.3

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…d features

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@GarthDB
GarthDB force-pushed the feat/consumer-smoke-eject branch from eafd397 to 7bc05d7 Compare October 20, 2026 17:28
@GarthDB
GarthDB merged commit 900b522 into main Oct 20, 2026
9 checks passed
@GarthDB
GarthDB deleted the feat/consumer-smoke-eject branch October 20, 2026 17:32
@GarthDB GarthDB mentioned this pull request Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant