feat: readable dimension-mismatch diagnostics - #30
Merged
Conversation
The BaseUnit member +, -, and comparison operators now accept an operand of any dimension and static_assert that the exponents match, so adding/subtracting/ comparing incompatible quantities fails with a clear message (e.g. 'utl: cannot add quantities of different dimensions') instead of an overload-resolution wall of 'no matching operator' notes. Same-dimension behaviour (including mixed precision and result-type mapping) is unchanged. Regenerated the single header; updated CHANGELOG and CLAUDE.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FUTURE_WORK v3.x quick win — the biggest day-to-day ergonomic improvement.
The
BaseUnitmember+,-and the six comparison operators now accept an operand of any dimension andstatic_assertthat the exponents match. A dimension mistake reports one line:instead of the previous overload-resolution wall of "no matching operator" + candidate notes.
std::common_type_t) and result-type mapping still apply; verified by the existing suite.operator+(Temperature, Activity, …) keep their behaviour.Verified locally: build (Werror), 48 tests, clang-format, zero-overhead, single-header
--checkin sync; andLength + Time/Length < Massnow emit the readable messages.