Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new static limelightProxyEnabled flag is not reset between dashboard restarts within the same process, which can incorrectly keep the proxy disabled.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds a build-time opt-out for FTC Dashboard’s Limelight proxy so teams can use other libraries (e.g., Panels) that bind the same ports without crashing the robot app.
Changes:
- Introduces
@DashboardSettingswith alimelightProxytoggle (default enabled). - Extends the existing dex scan to detect
@DashboardSettingsand conditionally skip starting the Limelight proxy.
File summaries
| File | Description |
|---|---|
FtcDashboard/src/main/java/com/acmerobotics/dashboard/FtcDashboard.java |
Reads @DashboardSettings during class scanning and gates LimelightProxyManager.start() based on the setting. |
FtcDashboard/src/main/java/com/acmerobotics/dashboard/DashboardSettings.java |
Adds a runtime annotation to allow disabling the Limelight proxy at startup. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Our team uses Pedro Pathing for autonomous navigation, and that library has a hard dependency on Panels for tuning its constants. However, our students prefer using FTC Dashboard for graphs, logs and tuning (thanks for making a nice and simple to use dashboard library!).
When the students updated FTC dashboard from 0.5.1 to 0.6.0, the robot app started crashing.
Root cause
FTC Dashboard 0.6.0 includes the Limelight proxy from #215.
Panels also includes a Limelight proxy that binds the same ports. When using both libraries, there's currently no way to stop FTC Dashboard from starting the proxy and when Panels starts, the Control Hub crashes due to both libraries trying to bind the port. Note that the crash happens whether or not there's a Limelight connected, as it's starting the proxy that causes the issue.
Steps to reproduce
Modify
build.dependencies.gradleto includeDeploy to robot and see the app crash on start.
Change
Add the annotation
@DashboardSettingswith one setting for disabling Limelight proxy. This annotation can be added to any class and will be picked up by the same scan that looks for the@Configannotation. If more settings are needed in the future, they can be added to the same annotation.Example usage