made 404 page responsive#78
Merged
Merged
Conversation
Himakiyay
commented
May 26, 2026
Himakiyay
commented
Collaborator
fixes #69
bgarcia11
requested changes
May 26, 2026
bgarcia11
left a comment
bgarcia11
left a comment
Contributor
There was a problem hiding this comment.
the small gears should only appear on small screen sizes and should not just replace the larger gears, otherwise the design is wrong on larger screen sizes. you need to import both sizes of gears to the file. alt text should never be left empty.
bgarcia11
requested changes
May 27, 2026
bgarcia11
left a comment
bgarcia11
left a comment
Contributor
There was a problem hiding this comment.
the large gears already exist in the 404-gears folder. they should not be re-added. the smaller gears should be moved there as well. you can rename the gears when you call them in at the top of the file, but they should be the same exact gear files.
add padding to the small gears so that they never touch on small screen sizes.
add padding to the large gears so that they never touch (this is tablet size).
…makiyay/404PageResponsiveness
bgarcia11
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.