[satellites] update satellites tracked#1004
Conversation
// added #41866 GOES-16 celestrak_weather // added #55506 ELEKTRO-L4 celestrak_active // added #67756 ELEKTRO-L5 celestrak_active // removed #53106(payload) = #53109(rocket body) = IO-117(Greencube), satellite decommissioned for all entries generated data_source field showing celestrak group data source
accius
left a comment
There was a problem hiding this comment.
Thanks for keeping the satellite registry current, and thanks to @creinemann for the source list.
Reviewed the diff — this is a clean, data-only update to server/routes/satellites-tracked.js:
- Adding GOES-16 (#41866) and ELEKTRO-L4/L5 (#55506/#67756) looks correct, and dropping IO-117/GreenCube on decommissioning is the right call.
- Converting the trailing
// CelesTrak group: ...comments into a realdata_sourcefield is a nice improvement — self-documenting and queryable rather than buried in a comment.
Two small notes, neither blocking:
data_sourceis currently informational only. The TLE fetch insatellites.jshardcodesgroups = ['amateur', 'weather', 'goes']and matches purely by NORAD ID. Thecelestrak_activeentries (QMR-KWT-2, ELEKTRO-L3/L4/L5) aren't in those group files, so they resolve via the per-NORAD CATNR fallback. That path already works for the existingactivesats, so the new ones will resolve the same way — just flagging that the field doesn't yet drive fetch behavior in case a future change wants to wire it up.- GOES-16 and the new ELEKTRO entries omit
mode/frequency. The merge logic insatellites.jshandles missing optional fields gracefully (||/??), so this is fine, but adding HRIT/LRIT mode + downlink frequency for the ELEKTRO sats (consistent with L2/L3) would round out the metadata if you have it handy.
CI is green and the branch merges cleanly into Staging. Looks good to me.
— K0CJH
|
@accius you said,
actually the 'data_source' field is utilized in the change to the
(my personal opinion only) is that the extra information is difficult to accurately maintain unless it is constantly being reviewed and updated, and could be dropped completely focusing OHC solely on location tracking and prediction |
|
@MichaelWheeley — fair points, thanks for the follow-up. On On dropping The plan: a background fetcher — same state-machine pattern as #1007 — refreshed daily, joined by NORAD ID, with the curated values in Appreciate you pushing on this. — K0CJH |
What does this PR do?
Type of change
How to test
Checklist
server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)var(--accent-cyan), etc.).bak,.old,console.logdebug lines, or test scripts included