Skip to content

parallel api calls - #180

Merged
absadiki merged 2 commits into
absadiki:mainfrom
thiswillbeyourgithub:parallel-api-calls
Sep 9, 2025
Merged

parallel api calls#180
absadiki merged 2 commits into
absadiki:mainfrom
thiswillbeyourgithub:parallel-api-calls

Conversation

@thiswillbeyourgithub

Copy link
Copy Markdown
Contributor
  • add a type hint
  • add parallel processing of chunk via joblib

For #178

I haven't tested it but it looked correct.

Signed-off-by: thiswillbeyourgithub <26625900+thiswillbeyourgithub@users.noreply.github.com>
Signed-off-by: thiswillbeyourgithub <26625900+thiswillbeyourgithub@users.noreply.github.com>
@absadiki

absadiki commented Sep 4, 2025

Copy link
Copy Markdown
Owner

Looks great! Thanks @thiswillbeyourgithub.
But It’d be better if you could take a bit of time to test it as well, just to make sure everything works as expected 😅

@thiswillbeyourgithub

Copy link
Copy Markdown
Contributor Author

I just tested the code and it worked fine. I don't seem to get the "print" appear in the docker logs, I recommend using loguru for this.

@absadiki

absadiki commented Sep 9, 2025

Copy link
Copy Markdown
Owner

Yes, using a logger is always better than using the simple prints.
Thanks a lot for testing. I'll go ahead and merge this for now.

@absadiki
absadiki merged commit ef00dc2 into absadiki:main Sep 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants