Report the Grindr conversation link counts instead of only a flag - #2017
Merged
Conversation
A conversation record holds no message text: it links to the messages, which the messages artifact reports. The artifact reduced those link lists to two booleans and discarded the rest, so a conversation could not be sized without opening it. The lengths of the message, tap message and member link lists are now reported. On the tested device that is 118 message links across 17 conversations, 9 tap links across 9, and 46 member links across all 23. Only the lengths are taken: the lists hold the store's own row references, and resolving those to rows is not something this artifact does. The 118 message links do not reconcile with the 129 rows in the messages artifact, so the notes say that a message can be present without a conversation linking it rather than implying the two agree. Draft Message and Name were empty on every row of the tested device. Both are kept, because an unsent draft and a conversation name are each significant wherever they are populated, but the notes now say they were uniformly empty rather than describing them as though they carried content. Row counts are unchanged on a single container and still exactly double on the two container tree. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Grindr conversation record holds no message text; it links to the messages, which the messages artifact reports. The artifact reduced those link lists to two booleans and discarded the rest, so a conversation could not be sized without opening it.
Now reported: the lengths of the message, tap message and member link lists. On the tested device that is 118 message links across 17 conversations, 9 tap links across 9, and 46 member links across all 23. Only the lengths are taken, since the lists hold the store's own row references.
The 118 links do not reconcile with the 129 rows in the messages artifact, so the notes say a message can be present without a conversation linking it rather than implying they agree.
Draft MessageandNamewere empty on every row. Both are kept, because an unsent draft and a conversation name each matter wherever populated, but the notes now say they were uniformly empty instead of describing them as carrying content.Row counts unchanged on a single container, still exactly double on the two container tree.