feat: include additional run information in lava file output - #1661
Merged
Conversation
Collaborator
Author
|
added |
JamesHabben
added
LEAPP Core
abrignoni
added a commit
that referenced
this pull request
Jul 26, 2026
…uches CI lints every changed Python file with warnings fatal, so touching a core file means inheriting whatever debt it already carries. ileapp.py, scripts/ilapfuncs.py and scripts/lavafuncs.py each carried enough to fail the gate on their own: PRs #1280, #1661 and #1719 are all currently red for this reason, #1719 while changing nothing but lavafuncs.py. Real fixes: - drop 13 global declarations that never assign the name - codecs.open -> open(encoding=...) for the TSV writer; codecs.open is deprecated and the utf-8-sig BOM behaviour is unchanged (verified against a before/after run) - bare except -> except (ValueError, TypeError) on the two json.load calls, which is what they were guarding - raise ... from ex when rejecting an unknown timezone, plus the stray six-space indent on that line - drop an unused local that shadowed datetime.timezone, and an unused exception binding - two f-strings with nothing to interpolate Suppressed with a reason rather than changed: - the backward-compatibility re-export block in ilapfuncs.py. Its own comment says those names are kept so older imports keep resolving, so unused-import does not apply. The same goes for re, codecs and leapp_name. - the three wildcard imports in ileapp.py. Both ileapp.py and ileappGUI.py resolve a large surface through them; unpicking that is a refactor of the entry point, not lint cleanup. - two deliberate catch-alls that log the traceback and keep going. - the global statement in initialize_lava, which is the one function that creates those module level singletons. - a TODO comment, reworded so pylint's fixme check stops failing the build over a note. All four files now rate 10.00/10. A full run over the same extraction produces byte-identical results: 0 errors, 50 populated LAVA tables, 29,615 rows, and the TSV files still carry their BOM. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Collaborator
Author
JamesHabben
removed
the
Needs Cross Core Leveling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finalize and close #1209
added info for: