Fold local storage view dedupe helpers onto the shared helper - #1137
Merged
Conversation
instagram.py, tikTok.py and chromePaymentsCustomerData.py carried their own earlier copies of the storage view dedupe that storagePathViews.unique_files() now provides. Routes the three modules through the shared helper and keeps the module-specific filtering at the call sites: the Web Data basename filter and the .magisk mirror skip in chromePaymentsCustomerData, and the suffix filters in instagram and tikTok. The local helpers in tikTok and chromePaymentsCustomerData dropped a file present only under data_mirror while the shared helper keeps one copy of it; a listing sweep of all 18 registered Android corpora shows no file matched by these modules' globs occurs only under data_mirror, so the selected file sets are identical on every registered image. Focused profile runs against pixel3_a11 and pixel3_a12 reproduce every recorded sample_data count unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folds the local storage view dedupe helpers in instagram.py, tikTok.py and chromePaymentsCustomerData.py onto storagePathViews.unique_files() from #1135. Module-specific filtering stays at the call sites: the Web Data basename filter and .magisk mirror skip, and the suffix filters.
A listing check of all 18 registered Android corpora shows the selected file sets are identical to the local helpers' on every image, and focused profile runs against pixel3_a11 and pixel3_a12 reproduce every recorded sample_data count unchanged.
🤖 Generated with Claude Code