Skip Chromium databases that cannot be read instead of ending the artifact - #1136
Open
abrignoni wants to merge 1 commit into
Open
Skip Chromium databases that cannot be read instead of ending the artifact#1136abrignoni wants to merge 1 commit into
abrignoni wants to merge 1 commit into
Conversation
…ifact Twelve artifacts opened each matching database with no guard around the query, so one unreadable file raised out of the loop and the artifact returned nothing for the whole image, dropping every browser already collected. SQLite treats a non-empty '<db>-journal' sidecar as a hot journal and starts a recovery that has to write, which a mode=ro handle cannot do, so the first statement raises 'attempt to write a readonly database'. pixel3_a12 carries such a file: the Gmail WebView 'Web Data' under data_mirror, whose sidecar is 16 bytes of LevelDB text rather than a rollback journal. Driving get_chromeAutofill over that file plus a healthy Chrome 'Web Data' from the same image raises on main and returns the healthy database's 3 rows here. That file is no longer reached in a normal run, because the storage-view dedupe added in #1135 selects the data/data spelling of the same database, so no registered corpus currently exercises the path. These are guards against a reachable failure rather than repairs of an observed one, and the full sweep below is unchanged by them. Covers chromeAutofill, chrome.py (Web History, Web Visits, Search Terms, Downloads, Keyword Search Terms), chromeCookies, chromeLoginData, chromeMediaHistory (Sessions, Playbacks, Origins), chromeDIPS, chromeNetworkActionPredictor and chromeOfflinePages. chrome.py and chromeMediaHistory route their queries through one helper each rather than repeating the guard, and report_file now lists only the files actually read. Sample data for both Autofill artifacts re-derived from aleapp.py profile runs over all 17 registered phone corpora, which also extends the recorded set from 10 and 12 corpora to 17. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
abrignoni
force-pushed
the
claude/goofy-noether-88279f
branch
from
August 16, 2026 20:52
747f0b2 to
30f487f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guards twelve Chromium artifacts so one unreadable database no longer ends the artifact.
<db>-journalsidecar as a hot journal and starts a recovery that needs to write, which amode=rohandle cannot do. pixel3_a12 carries one such file, the Gmail WebViewWeb Dataunderdata_mirror, whose sidecar is 16 bytes of LevelDB text rather than a rollback journal. Drivingget_chromeAutofillover that file plus a healthy ChromeWeb Datafrom the same image raises on main and returns the healthy database's 3 rows on this branch.data/dataspelling of the same database. No registered corpus currently exercises the path, so these are guards against a reachable failure rather than repairs of an observed one.report_filenow lists only the files actually read.Verified with aleapp.py profile runs over every registered Android corpus, main against this branch: no error banners either side and 25,774 rows either side, so the guards change nothing where nothing fails.