Pin artifact reference permalinks to commits - #1122
Merged
Merged
Conversation
Nine artifact modules cited GitHub reference files with links pointing at the upstream master or main branch, which keep resolving while the content behind them moves. This repins all 21 references (18 file links, 3 directory links) to the upstream default-branch HEAD commits after confirming at each commit the content the notes attribute to the cited file. Two citations now point at the file that carries the content: the Firefox places notes cite NSPR's prtime.h for the PRTime microseconds clause, and the Signal calls artifact cites CallTable.kt for the call Type, Direction and Event values. last_update_date is bumped for every artifact whose notes changed. No parsing changes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nine artifact modules cite GitHub reference files with links that point at the upstream master or main branch. Those links keep resolving while the content behind them moves, so a citation could drift away from the definition it cites. This repins all 21 references (18 file links and 3 directory links, across 7 upstream repos) to commit SHAs, the same treatment iLEAPP received in abrignoni/iLEAPP#1968.
Each upstream repo's current default-branch HEAD was resolved, the cited file was fetched at that commit, and the specific content the notes attribute to it was confirmed there before repinning: the places Timestamp milliseconds conversion in application-services lib.rs and its use for visit dates in places history.rs, the cookies schema 15 to 16 migration multiplying expiry by 1000, nsIPermissionManager ALLOW_ACTION=1 and DENY_ACTION=2, DownloadState.Status PAUSED=3 CANCELLED=4 FAILED=5 COMPLETED=6, the eleven LV03 to WGS84 conversion coefficients, Glide's DiskCache.Factory.DEFAULT_DISK_CACHE_DIR, the Proton Drive LinkDto type and state constants, Signal's expires_in stored in milliseconds, base type mask 0x1F with types 20 to 24 and 27, and call Type 0/1/3/4 with Direction 0/1 and Event 0 to 10, Telegram's 18 TL_message layer constructors including the second flags integer, the SharedConfig passcode keys, the per-prefix save-gallery keys read with a default of false, the AUTODOWNLOAD_TYPE masks 1/2/4/8 with the underscore preset layout, and the six named TlGen generated model files present in the pinned tree, including exactly eight TL_messageService constructors in TlGen_Message.kt.
Two citations were adjusted while verifying them. The Firefox places notes credited application-services lib.rs with the desktop PRTime microseconds contrast as well as the milliseconds claim; PRTime appears nowhere in that file at any revision, or anywhere else in application-services. Those notes now cite lib.rs for the milliseconds claim and NSPR's prtime.h, which defines PRTime with microsecond units, for the microseconds clause. The three Signal notes cited MessageTypes.java under a label naming both MessageTypes.java and CallTable.kt; the call Type, Direction and Event values the calls artifact reports are defined in CallTable.kt, so that artifact now cites CallTable.kt, and the messages and attachments artifacts keep MessageTypes.java with the label narrowed to what it contains.
last_update_date is bumped for the artifacts whose notes changed. No parsing changes. Every rebuilt link was fetched back as written (the split string literals reassembled from the parsed module) and returns the cited file, pylint with the CI flags is clean on all nine files, all 788 artifact modules load through the plugin loader with no duplicate names, and the claim-language and sample_data checkers report no errors.
🤖 Generated with Claude Code