fix: drop the unimplemented bytes header type - #1087
Merged
Conversation
No consumer branches on a 'bytes' header type: ALEAPP's report and LAVA writers act only on 'media' and 'datetime', and LAVA has no bytes renderer. The type was ignored at render but still written into the LAVA manifest's object_columns, where it would become live behavior the day a renderer exists, with no review of this use. Plain text cannot misbehave. Same reasoning as the removed 'url' type (PR #1060). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
honorMediaLibrary declared a ('File Size', 'bytes') header. No consumer implements a bytes type (report and LAVA writers branch only on media and datetime), so it fails open: ignored at render, but written into the LAVA manifest's object_columns where it would activate retroactively the day a renderer exists. Stripped to plain text, same reasoning as the removed url type (#1060). The matching iLEAPP case in filesApp.py gets its own PR. smartSidebarFileDock had the same type removed during the #958 review.
🤖 Generated with Claude Code
EOF