Repository navigation
Conversation
Stream readers must ignore payload kinds they do not recognise so a newer server can add kinds in a minor version without breaking older clients. The JSON-RPC and REST SSE parsers and the gRPC and slimrpc clients previously turned an unknown StreamResponse payload into an error; they now skip it. Malformed JSON and transport errors are still reported. Re-vendor a2a.proto from the A2A main branch (v1.0.1 plus the tenant documentation and gRPC URL example fixes). Signed-off-by: Mauro Sardara <msardara@cisco.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
A tail that is a JSON-RPC success whose result holds only an event kind this client does not know is skipped on purpose, as the spec requires of stream readers, so the tail oracle no longer treats it as silently dropped data. Signed-off-by: Mauro Sardara <msardara@cisco.com>
Only a payload kind this client does not recognise is skipped. An event with no payload at all (an empty JSON object) is malformed, so it is reported as an error instead of being skipped with the unknown kinds. The fuzz oracle for a skipped tail now requires a non-empty result. Signed-off-by: Mauro Sardara <msardara@cisco.com>
msardara
changed the title
Tehsmash
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base of the A2A 1.1 stack; schema changes follow in #385.
Skip unrecognized stream payload kinds across all four client transports while preserving malformed-event errors where the binding can distinguish them. Sync upstream protobuf comments without wire changes.