Skip to content

Repository navigation

test: review workflow #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Zfinix wants to merge 1 commit into from
Closed

test: review workflow #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/aster-policy/src/rule.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ impl Rule {
// also match `rmdir`.
Match::CommandPrefix(prefix) => match line.strip_prefix(prefix.as_str()) {
Some("") => true,
Some(rest) => rest.starts_with(char::is_whitespace),
Some(rest) => !rest.starts_with(char::is_whitespace),

@github-actions github-actions Bot Oct 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CommandPrefix match condition inverted, bypassing prefix rules — critical/security · 98% confident

The rule meant to catch commands starting with rm ignores a real rm -rf / command, so dangerous commands can slip through, while it also flags unrelated commands like rmdir.

Fix: Revert the negation: Some(rest) => rest.starts_with(char::is_whitespace), so a prefix only matches when followed by whitespace (or end-of-string via the Some("") arm).

None => false,
},
Match::Path(_) => false,
Expand Down
Loading