Skip to content

test(sdk-broker): align two delete-replay fixtures with #6339 contract #6347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yeachan-Heo merged 9 commits into from
Oct 5, 2026
Merged

test(sdk-broker): align two delete-replay fixtures with #6339 contract #6347

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0ce574e
fix(sdk): restore session.delete pending dispositions broken by #6339
Oct 5, 2026
8302f2d
fix(sdk): allow cleanup replay without mandatory managed scope verifi…
Oct 5, 2026
fba2773
Revert lifecycle.ts to origin/dev per #6347 test-only fix
Oct 5, 2026
55a691f
Revert lifecycle.ts to post-#6339 state (remove commits 0ce574e and 8…
Oct 5, 2026
b34167e
Merge remote-tracking branch 'refs/remotes/origin/dev' into fix/6339-…
Oct 5, 2026
d3cd5cd
test: reset sdk-broker.test.ts to dev before fixture-only fix
Oct 5, 2026
4c04ca1
test(sdk-broker): provision managed scope and track #6339 response wo…
Oct 5, 2026
e7972a7
Merge remote-tracking branch 'refs/remotes/origin/dev' into fix/6339-…
Oct 5, 2026
5c5ff5a
test(sdk-broker): drop scope provisioning now that #6357 restores own…
Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/coding-agent/test/sdk-broker.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3386,7 +3386,8 @@ describe("SDK broker identity and discovery", () => {
await broker.start();
const transitionSpy = vi.spyOn(broker.ledger, "transition").mockImplementation(async (...args) => {
const result = await transition(...args);
if (!canonicalInjected && JSON.stringify(args[2]?.response).includes("artifacts were removed")) {
// #6339 reworded the durable artifact-completion response to "artifacts are removed".
if (!canonicalInjected && JSON.stringify(args[2]?.response).includes("artifacts are removed")) {
canonicalInjected = true;
await fs.mkdir(artifactsDir);
await fs.writeFile(path.join(artifactsDir, ".reappeared"), "reappeared");
Expand Down Expand Up @@ -3980,7 +3981,8 @@ describe("SDK broker identity and discovery", () => {
const transcriptParent = path.dirname(sessionPath);
const renamedTranscriptParent = `${transcriptParent}.renamed`;
await fs.rename(transcriptParent, renamedTranscriptParent);
await fs.mkdir(transcriptParent);
// The replacement must still pass managed-scope security (#6339) so replay reaches receipt validation.
await fs.mkdir(transcriptParent, { mode: 0o700 });
const replacedParentReplay = await broker.handleRequest(
"session.delete",
{ sessionId, sessionPath, cwd },
Expand Down
Loading