Skip to content

feat(acp): consume staged lossless images with owned echo fences [5879 stack 3/3] - #6311

Closed
snowykr wants to merge 47 commits into
devfrom
pr5879-stack-3-acp-images-d4-20261004
Closed

feat(acp): consume staged lossless images with owned echo fences [5879 stack 3/3]#6311
snowykr wants to merge 47 commits into
devfrom
pr5879-stack-3-acp-images-d4-20261004

Conversation

@snowykr

@snowykr snowykr commented Oct 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What / Why

ACP inline-image consumer over the exact SDK lifecycle; dev-targeted diff is cumulative.

Current publication — two proven public terminal regressions corrected

DRAFT / NOT READY / NOT MERGE-APPROVED. Original PR5879 SDK/ACP scope only; no unrelated stabilization, P1 replay or withdrawn #6351 owner-manager architecture.

Role Exact current head Tree
SDK #6310 4296ce7cf5a0b2035f597e3167d04582c7b86846 c7e119213cac2ae6dc69eb3847c2ba076d834e5c
ACP #6311 9d2e9f991c4bef0459fe53ad1d0d2edd2a744fc0 9a0a1f76153a090ba31ad94b74e2402f727a5ffd
Independent reference db511f775e02c9c448dde508c41f983379128555 8fd4cc62a4e3dcbe3c4495ccb5fcda375e0aef54

Frozen current dev db03185d5d45e0bf9bd31dc8fda0af2156e9c574 and #6309's maintainer merge remain preserved. ACP has current SDK as a true ancestor. Restack used a temporary clean Git-only worktree, removed only after clean verification; generated native outputs were neither stashed nor committed. All three owned refs were pushed atomically with explicit predecessor leases and read back. Independent reference was authored reference-first; its published fix is only the one-line public correction, not the experimental handoff.

Unrestricted exact Git totals: SDK cumulative vs frozen dev 38 files (1 binary), text +5381/-574; ACP marginal vs SDK 10 files (0 binary), text +1882/-121; ACP cumulative vs frozen dev 47 files (1 binary), text +7235/-667. No exclusions or size-policy waiver. These current metrics supersede earlier body totals.

Bounded correction and exact-head verification

Only the redundant outer await extensionDelivery was removed from AgentSession's deferred publisher. Ordinary public prompt/idle settlement no longer waits on a deliberately blocked extension. SDK-owned publication retains its inner extension await, and its producer discovery/release still follows actual extension delivery. This restores existing public semantics; no new API or release surface, assertion, product deadline or ownership fallback was introduced.

  • Current SDK: both original public/shutdown-extension regressions 2 passed / 3 assertions; SDK-only queued-terminal shutdown/lease cases 10 passed / 249 assertions; complete queued-prompt suite 10 passed / 57 assertions.
  • Current SDK complete message-pipeline file: 25 passed, 1 failed, 76 assertions. The exact unresolved SDK worker checkpoint and its logs are retained; no whole-file green is claimed.
  • Current ACP: the same two original regressions pass; complete ACP watchdog 53 passed / 263 assertions; coding-agent package check exits0 with existing warnings retained, no suppression. These are clean product/test, exact-head receipts with before/after HEAD/diff invariance; generated platform outputs are recorded separately and not committed.
  • Prior pure-policy heads (ffba6ffa SDK / 5301d8d4 ACP) passed runtime/canonicalization, upload-store 31 / 3,583 assertions, pasted loading 18 / 28 assertions, and ACP watchdog 53 / 263 assertions. Those receipts are predecessor-scoped, not relabeled as current-head runtime passes. Six original restriction constants/comparisons and policy blobs remain unchanged.
  • Current complete committed reference-vs-ACP tree comparison has exactly the same six residual paths, modes, statuses and blob IDs as policy predecessors. All residual bytes, full binary patch and raw inventory were persisted and read back with hashes. Previously approved extraction/release semantics carry only because residuals are byte-identical; no frozen-cohort/runtime/maintainer approval is inferred.

Remaining PR-related blockers — no readiness inflation

All three original pipeline cases passed on independently built immutable dev with the same Bun1.4.0. Thus the unresolved SDK case is not dismissed as an upstream flake: worker dispatch starts at turn_end while actual terminal continuation decisions are still pending. An experimental scope/lease handoff did not fix it. Its full pipeline run also recorded25pass/1fail; diagnostic logging was removed. The remaining candidate is uncommitted and unpublished, advisory review remains BLOCK/REQUEST CHANGES. No early final-disposition claim, skipped stop gate or delayed worker request is shipped without proving continuation/cancellation/request obligations.

Previous complete exact-head hosted SDK37404851913 and ACP37404855018 runs failed; all50job metadata and all41non-skipped logs perrun remain archived/readback-verified. Image canonicalization and two proven public-ordering regressions are corrected, but old hosted evidence is not current-head completion authority. Host-wiring timeout/crash reds remain preserved, not erased by isolated passes. Full successor local/hosted matrices/logs, all original STACK-AC01..10/AC05/AC10/AC11 and G013 preparation, fork/consumer/adversarial proof, frozen cleaner/Architect/typed-QA cohort, terminal Critic, strict native validation and aggregate receipt remain required before Ready. No maintainer approval, merge, stock Paseo/browser E2E or shared-daemon restart is claimed. Original #5879 and protected primary main remain unchanged.

Preserved predecessor and historical notes — not current-head proof

What / Why

ACP inline-image consumer over the exact SDK owner. This dev-targeted diff is cumulative, not just its marginal consumer files.

Current verified publication — pure image policy correction

Draft / not ready / not merge-approved. This remains the original PR5879 progressive stack, not repository-wide stabilization.

What changed

An import-free image policy module owns the existing six restriction constants. All values and comparisons remain unchanged; obsolete loader exports are removed and consumers import policy directly. This resolves the demonstrated ACP canonicalization cause: policy-only imports previously pulled path-utils → MCPManager and internal-URL/session mutation dependencies into a machine consumer. No verifier, product deadline, assertion or native architecture was weakened. All original STACK-AC01..10, AC05/AC10/AC11, G013 preparation and maintainer merge authority remain intact.

Exact successor evidence

  • SDK: runtime/canonicalization checks pass; complete upload-store suite 31 passed / 3,583 assertions.
  • ACP: runtime/canonicalization checks pass; complete upload-store suite 31 passed / 3,583 assertions; pasted-image loading 18 passed / 28 assertions; watchdog 53 passed / 263 assertions.
  • The publication worktree had clean product/test source for those commands. Two explicitly recorded native-generated platform outputs are uncommitted. Native addon built locally; doctor resolves 9/9 workspaces and loads it. SDK/ACP native dependency source is identical.
  • An initial SDK runtime invocation was terminated by an outer 180-second process window, not a failed product assertion. Its rerun allowed the retained 1200-second runner window and completed successfully; no internal test/product deadline changed.
  • Complete unrestricted committed reference-vs-ACP comparison still contains exactly six previously source-reviewed test/release residuals, with no exclusions. This is not new whole-runtime/final-cohort/maintainer approval.

Retained failures and bounded attribution

Previous exact-head full nonpublishing CI ended failure, not green: SDK 37404851913 failed coding-agent shards4/16 and16/16; ACP 37404855018 failed shard16/16 and runtime-check. All50job metadata and all41non-skipped logs per run were archived with SHA256/readback; required aggregate failed closed.

Canonicalization is corrected above. Three message-pipeline failures cannot be dismissed as unrelated dev flakes: each unchanged test passed on an immutable dev worktree built from its own native source with the same Bun1.4.0. SDK's AgentSession changes affect terminal ordering. A local public extension-barrier correction passes two original cases; SDK worker checkpoint remains unresolved. That experimental terminal handoff and wiring fixture work are uncommitted/unpublished, and no whole successor lifecycle/hosted green is claimed. Ordinary public settlement, SDK-owned extension delivery, actual retry/compaction/todo/goal/deep-interview decisions, producer/cohort/continuation authority and real queue cleanup must remain intact, without changing test expectations.

Wiring timeout/crash receipts remain preserved; isolated greens do not erase whole-file reds. No unrelated broker/native refactor or general flake cleanup is authorized here. Full local matrices, complete successor hosted results/logs, individual adversarial/fork/consumer proof, frozen cleaner/Architect/typed-QA cohort, terminal Critic, strict native validation and aggregate completion remain required before Ready. Original #5879 and primary main remain unchanged; no merge or stock Paseo/browser E2E is claimed.

Preserved earlier publication notes — not current-head proof

What / Why

P3/3: complete ACP inline-image consumption over the staged SDK lifecycle in #6310. Preserve bytes/MIME and full-frame bounds, staging/envelope validation before echo, request-owned watchdog/cancellation/socket/echo fences, fresh-ID retry only after confirmed retirement and original-clientRef recovery without mutation replay. Pending/failed echo barriers survive same-ID replacement and recordless recovery, retaining failed publication until explicit retirement. No Paseo patch, image transcoding or resource_link requirement.

ACP marginal vs SDK: 10 files, +1,883/-121. Cumulative vs current dev: 43 files, +7,219/-658. This dev-targeted PR is cumulative, not a ten-file standalone diff.

Current publication status — Linux continuation

This updates the existing PR after transferring the source session and its execution goal/ledger; it does not create a replacement PR or narrow the outstanding acceptance. Draft / not ready / not merge-approved.

Fresh local evidence and limitations

  • Independent reference baseline a2e5e2ce9: complete SDK runtime 233 passed / 0 failed / 3,473 assertions, queued prompts 10 passed / 58 assertions, package checks passed. These are reference-scoped results, not a claim that the new SDK/ACP full matrices passed.
  • The independently amended reference's watchdog suite passed 53 tests / 263 assertions, with package/type/lint checks and existing diagnostics retained. The propagated ACP head c76ab3de8c2a5fdee4a6bb4133229b7bea011d23 independently passed the complete watchdog suite 53 tests / 263 assertions and session-ID/fork suite 21 tests / 83 assertions, including real 2 MiB saved-ID preservation, parent/child reopen and independent writes.
  • ACP release note now explicitly retains failed publication until retirement. A vacuous cleanup observation in the held-begin test now joins the real operation response before testing retirement; product code, cancellation assertions and internal deadlines were not weakened.
  • Full SDK host wiring at predecessor aa210c6d1 remains 154 passed / 4 failed / 1 separate error. A grouped reproduction remained 0 passed / 4 failed / 1 error. Later isolated diagnostic runs passed but do not erase the red or establish a sole cause. The wiring/product blobs were not changed by the watchdog-only successor. Real broker startup and timeout/fixture cleanup lifetime remain an open blocker.
  • The old 300-second outer process cutoffs remain recorded. The unchanged 233-test reference suite completed with a sufficient whole-process window; source test guards were not increased.
  • Unrestricted reference/ACP tracked-tree comparison has exactly six residuals, no exclusions: three test extraction residuals and the unsplit-to-SDK/ACP release fragments. Exact-source advisory reviews classify all six as contract-preserving. This is not maintainer, runtime, final-cohort or native checkpoint approval.

Outstanding acceptance / readiness

Current per-head lifecycle/affected-path/Rust/generated/daemon matrices, complete exact-head hosted jobs and logs, individual adversarial/fork/consumer proof, frozen cleaner/Architect/typed-QA cohort, terminal Critic, strict native validation, publication receipt and aggregate completion remain outstanding. Historical source receipts and active Mac jobs are not live Linux completion authority. Stock Paseo/browser E2E is not claimed.

G013's existing authorization to switch to ready automatically remains valid only when preparation gates pass; no additional permission is awaited. No original #5879 update/closure, protected Mac native change, shared-daemon restart, or merge was performed. SDK must merge before ACP under maintainer authority, followed by fresh integration/review after any predecessor/base change.

Preserved historical D15/D14/D13 publication notes — not current-head evidence

The following is the prior publication narrative, retained verbatim as history. Its “current” wording and approvals/tests apply only to its recorded earlier heads, not the Linux successors above.

What / Why

P3/3: complete ACP inline-image consumption over the staged SDK lifecycle in #6310. Preserve original image bytes/MIME and the 256 KiB complete-frame limit; stage and validate the envelope before user echo, use request-scoped staging progress, restage fresh IDs only after confirmed busy cleanup, preserve consuming-run ownership and durable cancellation uncertainty, and recover the original clientRef through read-only result queries without mutation replay. Session-keyed pending/failed echo barriers survive same-ID replacement and recordless gaps. This does not patch Paseo, transcode/compress images or require resource_link.

The SDK owner retains current authenticated cold recovery, exact SHA-only recertification/disposal, immutable task-owner retirement, atomic readiness and the new independently authored cleanup-owner optional-field wire correction. Current upstream Codex partial-call retry and provider veto authority is preserved, not replaced by a consumer oracle.

Immutable stack / dependencies

All PRs target dev. #6309 was externally merged at exact 71fc4e410e7633ceaf221b3a06ccf18b1c0b532d, merge 849862112611bfc807f7d62c05a241a1701504d2; Main did not merge it. No P1 replay.

  • Frozen dev: bb00f4c8f2794ae51678d3ab38f8042a917763a6.
  • Owning P2 feat(sdk): stage lossless authenticated images across both hosts [5879 stack 2/3] #6310: 7c84e54b0e8072944c3e4e60321da45efccf1fdc, tree 75ed7a54f6e2acb37aa279468fb5c8d5805abbb4, 30 files +4247/-446 against dev.
  • Prepared P3 head: d74b27cf5c99202dbcf1e1c3955aad5354f1284f, tree f0c7bc89bd552a6c6897d7f5cc251a6c5c5aba7d.
  • P3 marginal vs P2: 10 files +1879/-121. Cumulative vs dev: 39 files +6098/-539. This dev PR is cumulative and must not be described as a ten-file standalone diff.
  • Merge P2 before P3; predecessor merge or another source/base change requires fresh integration, verification and review. No merge authorization is granted.
  • Independently constructed reference: b47627a7fed78413910031853d49ce2f39a99efe, tree 5755136bcbec73f8b357df09954e5294ca04c39e. Its correction0756 precedes named SDK propagation; P3's seven consumer commits were rebased onto that owner, never used to initialize the reference.

Actual verification / retained failures

Prior exact-head full D13 runs 37254705885/e5f695c67 and 37254707828/7f58c5cd failed. Both shard-1 jobs failed the same three SDK broker cases; P3 shard-5 additionally failed detached-owner finalize with owner-not-live. Full job API logs/head associations, byte hashes and artifact readback are retained; required-shard evidence producers correctly refused them. No hosted green claim or failure erasure.

The three SDK cases reproduced on untouched dev f4b and independent36a. Independent owner-field projection/fixture corrections passed the complete 112 broker/strict-owner-validation/deletion tests, final three cases/45 expectations and package check; selected SDK successor cases/package also passed. Present owner evidence and replacement-scope rejection stay strict. Cleared optional fields match persisted JSON, without invented retirement flags or borrowed owner effects. The separate local detached-owner short-root repeat passed unchanged assertions; it does not prove the hosted failure's sole cause or a product fix.

D13 P3 and reference each completed their original 58-file/2259-test lifecycle and joined affected/Rust/type/generated/daemon gates. The missing original-clientRef reconnect/no-replay suite actually ran at both exact D13 heads: four tests/28 expectations passed. Current complete manifests include this actual file rather than similarly named provider-lease coverage. Current exact-head P3/reference/P2 lifecycle/affected-path/native chains are running; full D14 completion is not claimed yet.

The benchmark counterequality failure and unchanged full successful repeat, deeply nested 50001-file/20-second native failures and unchanged short-root passes, initial D13 skipped recertification cases, cold/disposal failures, wrong argv/provenance and all predecessor/supersession evidence remain retained. No count/budget/native-guard waiver, hidden assertion suppression, or fake terminal fixtures.

Equality / review / readiness limits

Unrestricted current reference-vs-P3 inventory has six full individually enumerated binary residuals, exact statuses/modes/blobs/lengths/hashes and actual persisted readback; production/docs/generated bytes are equal, with no exclusions or blanket fixture exemption. Residual acceptance, fresh frozen same-authorized cleaner/Architect/typed QA, terminal Critic, strict native errors[], complete exact-head hosted jobs/logs/reviews, publication receipt and durable aggregate remain distinct unfinished duties.

Historical COMMENT reviews 5404807252/5404807327 bind old D4 heads, not this head. No current maintainer approval, terminal cohort verdict, size-policy exemption or merge approval is claimed. Draft remains until G013 preparation conditions are met; Main is already authorized to mark ready autonomously then and verify API isDraft=false. Current merge verdict: needs-human / not merge-approved. Full CI must pin actual base/head/repository/event and inspect guards, producers and every required shard/log; canary-only integration is insufficient.

Stock Paseo v0.9.1 browser E2E has not run. Original PR #5879, primary2af/protected native bytes and daemon6767 remain untouched.

Current D15 integration and actual D14 outcomes

Actual frozen dev bb00f4c adds persisted/restored canonical task-owner managers, failure propagation before persistent output allocation, and eight hashline read-snapshot generations. Main independently merged reference b476 before SDK7c84 and ACPd74; no split-derived reference or P1 replay. Current reference passed all four changed regression files: 158 tests, full SDK broker/strict owner/deletion 112 tests, full transport 63 tests, and package check. Current consumer's complete host-wiring 157 tests, transport 63 tests, and package check passed; these are fresh source-bound checks, not whole current-source completion.

Historical D14 SDK bbed: full 50-file/1935-test lifecycle, zero failures,10 skips, affected-path union and all eight local gates passed; actual full hosted dispatch 37262002245 completed success,54 jobs inspected for immutable associations with complete API log capture/hash/readback. Historical D14 ACP58c: full 59-file/2262 passed,1 failed,10 skips, solely session_closed debug record count; independent4316 separately failed one transport fixture with SDK broker unreachable. Those failures remain retained. ACP full hosted dispatch 37262004466 had all eight coding-agent shards successful but Windows doctor job111611136568 failed legitimate-holder convergence with native owner_mismatch; required producer111620406503 and aggregate111620446932 failed closed. All54 actual job associations and complete non-skipped logs captured/read back. A restricted immutable review classified the Windows issue WATCH: STATUS_ACCESS_DENIED loses syscall provenance; no confirmed SID mismatch, safe contention retry, guard weakening, or sole-cause explanation is authorized.

Complete D15 local per-layer/reference and actual full exact-head hosted gates remain pending. Seven D14 individual-case artifacts map54 scoped concrete cases with actual log/source/readback checks, explicitly separating controlled fixtures, real AgentSession, authenticated native sockets and whole-file inference; they are historical to D15 and not final independent QA. No old CI or review certifies these new source heads. Review readiness is separate from final aggregate/merge readiness; automatic G013 draft-to-ready authorization remains valid once actual relevant source-bound checks, required hosted gates and independent safety proof are prepared. No additional user approval is awaited.

Final hosted readback — Linux continuation (2026-10-06)

  • Published head remains 9d2e9f991c4bef0459fe53ad1d0d2edd2a744fc0; DRAFT / NOT READY / NOT MERGE-APPROVED.
  • Exact published-head workflow 37418828912 is completed: FAILURE, 20 jobs: affected-path plan, its evidence producer, and aggregate. Every non-skipped terminal job log was captured locally with SHA-256 and byte readback; no fetch errors. This supersedes earlier in-progress check snapshots, not historical source-bound failures.
  • The plan fails closed because this head lacks immutable event base 8d70ea74ea6008197dd7c39ba92b3848d5ae3838; the evidence producer fails on the absent plan artifact. These are preserved ancestry/plan failures, not relabeled product-test failures.
  • Local reference/SDK/ACP successors independently inherit accepted dev through bfa45ba61385f15a3851652e29325b35d9c3a8c9; they are unpublished. Their unrestricted six-path reviewed residual inventory is unchanged, with no path exclusions. Native Linux rebuilt for the changed pi-iso dependency, doctor resolves 9/9 and loads the addon. Exact local ACP e73f2734253b0d0af836f21f9e0068d75b5cace2: inherited cancel/symlink regressions 65 passed / 410 assertions, package check exits0 with existing warnings retained. These candidate gates do not certify this published head or an unfinished callback repair.
  • Full lifecycle/fork/consumer/adversarial matrices, host-wiring obligations, frozen review cohort, strict native final validation and aggregate preparation remain outstanding. No Ready transition or maintainer approval is claimed.

@snowykr snowykr mentioned this pull request Oct 4, 2026
Merged
3 of 5 tasks
snowykr
snowykr commented Oct 4, 2026
View reviewed changes

@snowykr snowykr left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main relay of fresh independent read-only 31-P3D4MarginalSafety exact P2..P3 OKAY/CLEAR, not maintainer/terminal approval. Actuala742bf78/treeccf72ed1 basedba61/D461f2; readfivepaths ACPagent/SDKadapter/watchdogtests/SDKdocs/equalitymanifest and unrestricted currentrawtreeinventory. Original bytes/MIME/full-frame cap and staged-envelope-before-echo retained (not later model/admission failures); local cancel/socket send barriers, confirmedcleanup-only busyfreshIDs and original-ref result recovery without mutationreplay. AC10 session-keyed pending AND failed echo tails survive same-ID replacement/recordlessgap, failure reaches current replacement, latecompletion can'tdelete failed owner. Five real recovery cases retained. Current fullcomparison independently observed exactly7specifictest/releasepaths withactualGitblobs/modes matchingmanifest; product/generated/docs equal. Reviewer didnot recompute suppliedperpatchdigests or historicalconstruction/tests, run gates or mutate. Main2375TS means2162lifecycle+213tests acrossfourupstreamfiles, NOT2162+4+213;170Rust exactsource. Scoped advisory not all39file/cohort/hostedCI/browser/merge approval. Native draft and predecessor order remain. StockPaseoE2E notrun; original#5879 unchanged.

@snowykr
snowykr force-pushed the pr5879-stack-3-acp-images-d4-20261004 branch 2 times, most recently from 3924e77 to 2badb0b Compare October 4, 2026 12:02
@snowykr

snowykr commented Oct 4, 2026

Copy link
Copy Markdown
Collaborator Author

Published predecessor-blocked native draft P3 2badb0bc88b6daff48a42a8c66f9c82947dec011, atop P2 ddabcd19f446d442ad6aebf238b479e5e24c758a and pinned dev dc0c6948671740e9363c9ca15359b2edaeba017d. Immutable marginal: ddabcd19f446d442ad6aebf238b479e5e24c758a..2badb0bc88b6daff48a42a8c66f9c82947dec011. Exact clean-head watchdog, full cancellation-settlement, reconnect/dispatch-observer uncertainty, unchanged autorouting, 15 upstream files/640 tests, package/type, generated inventory/manifests, daemon guard and 171 private Rust tests passed. D7 full-workflow reconnect failure came from obsolete fixture assumptions about absent router options; the correction was independently authored on the unsplit reference and exercises an explicit original-connection/generation dispatch observer while retaining clientRef/session-bound recovery/no replay assertions. Earlier source-bound base-authority, clock, and broker failures remain preserved separately; no sole causal-cleanup claim. Full affected-path CI is dispatched without virtual-only head_sha; virtual green remains canary evidence only. P3 stays a draft until separately authorized predecessors merge and fresh rebase/verification/review. No browser/maintainer/merge approval or final cohort claim.

snowykr added 8 commits October 4, 2026 23:38
@snowykr
feat(sdk): stage connection-owned images across both session hosts
5f72a96 
Complete SDK staging preserves bytes and MIME within the existing frame bound. Charge real retained and decode/copy allocations, bind accepted capacity to consuming execution, and expire inactive batches without unrelated renewal.

Lore-id: pr5879-p2-historical-01a10227
Constraint: complete standalone and notification hosts together
Confidence: high
Scope-risk: wide
Tested: package typecheck
Not-tested: frozen-head SDK runtime union pending
@snowykr
test(sdk): isolate terminal cases and exact-run settlement proof
cac49fe 
Aggregate case budgets and an always-settled abort stub obscured lifecycle truth. Isolate the unchanged evidence matrices and distinguish retained predecessor settlement from live-root aborts with real ledger proof.

Lore-id: 5879a106
Constraint: keep the 500ms run deadline and strict successor isolation assertions
Confidence: high
Scope-risk: narrow
Reversibility: easy
Tested: full SDK-only runtime 197 tests; full primary host 156 tests; package Biome and TypeScript checks
Not-tested: hosted CI and stock Paseo browser E2E at this historical layer
@snowykr
fix(sdk): enforce elapsed upload expiry before cleanup callbacks
701e46c 
Timer delivery can lag the inactivity deadline and otherwise resurrect expired uploads. Enforce elapsed validity at admission, ownership, redemption, renewal and asynchronous finalization while retaining charged in-flight reservations.

Lore-id: 5879a105
Constraint: preserve original bytes and MIME, private 256KiB frames, authenticated ownership, quotas and no replay
Confidence: high
Scope-risk: narrow
Reversibility: easy
Tested: upload store 31 tests; dual-host runtime and host 353 tests; package type and format checks
Not-tested: stock Paseo browser E2E
Directive: AC05-ELAPSED-EXPIRY-REPAIR is an explicit reviewed historical product correction, not an extraction-only difference
@snowykr
fix(sdk): retain merged generic retirement with image resource cleanup
17602a3 
The feature replay was conflict-free but reintroduced image-coupled retirement and generation 201. Apply the named shared-SDK integration correction from independently merged R3, preserving generic terminal retirement and image capacity as distinct owners. Generation 202 fences the already-merged image-free predecessor.

Lore-id: 5879a123
Constraint: preserve exact generic run ownership independently of image quota
Confidence: high
Scope-risk: wide
Reversibility: clean-revert
Tested: equivalent independent merged source owner and host matrices
Not-tested: full exact upper successor gates
@snowykr
test(session): publish complete writer readiness metadata atomically
8b3c396 
An existing ready filename was visible before its JSON write completed, causing the parent reader to fail with EOF in hosted CI. Write and fsync an exclusive private inode before linking the ready name; preserve no-replace behavior and all real managed-writer, descriptor identity and acknowledgement assertions.

Lore-id: 5879a122
Constraint: do not weaken managed-owner authority or writer exclusion
Confidence: high
Scope-risk: narrow
Reversibility: clean-revert
Tested: full owner-access suite and two complete interprocess boundary repeats
@snowykr
test(sdk): synchronize generation-202 inventory and authority fixtures
fc4e531 
Regenerate the owned SDK inventory and semantic daemon manifest from the reconciled SDK source. Keep the durable topic-registry fixture pinned to the actual serving generation without weakening the inherited guard or changing shared runtime defaults.

Lore-id: 5879a124
Confidence: high
Scope-risk: narrow
Reversibility: clean-revert
Tested: source-derived generation repair, generators and package check
@snowykr
merge(session): retain SDK image layer on owned native base
11d519d 
Preserve the complete independent SDK layer and merged P1 while integrating actual release, authenticated sibling inventory and native descriptor guards. Retain the observed upstream poisoned-scope timeout for fresh verification.

Lore-id: 5879a127
Confidence: high
Scope-risk: wide
Reversibility: clean-revert
Not-tested: fresh D10 upper gates
@snowykr
merge(storage): retain SDK images with authenticated logical owners
4c20f1e 
Preserve complete SDK and merged P1 ownership while integrating actual logical-owner storage checks and acknowledged cancellation baseline.

Lore-id: 5879a129
Confidence: high
Scope-risk: wide
Reversibility: clean-revert
Not-tested: fresh upper D11 gates
@snowykr snowykr mentioned this pull request Oct 4, 2026
Draft
@snowykr
snowykr force-pushed the pr5879-stack-3-acp-images-d4-20261004 branch from 2badb0b to 51c96eb Compare October 4, 2026 18:43
snowykr added 7 commits October 5, 2026 06:16
@snowykr
merge(sdk): retain current fenced retirement and retry correlation
e30ef57 
Integrate the actual current predecessor without replaying the maintainer-merged P1. Preserve all image-resource owners alongside the new generic retirement/deletion and retry lifecycle identity contracts.

Lore-id: 5879a132
Constraint: generic retirement is distinct from image quota ownership
Confidence: high
Scope-risk: wide
Reversibility: clean-revert
Not-tested: full current upper union and hosted gates
@snowykr
docs(bench): cite the actual compile-argument source
fd82b07 
The newly merged benchmark document used a package-relative script citation from the root docs tree. Point to the actual tracked package script so the real doc-source audit remains strict.

Lore-id: 5879a133
Confidence: high
Scope-risk: narrow
Reversibility: clean-revert
Tested: full real-tree doc-source audit
@snowykr
fix(session): authenticate existing scopes before cold cleanup replay
9adf1e8 
A resolved path is not task-owner cleanup authority. Reuse existing-only binding, security and inode capture before direct cold recovery, with immutable scope configuration checks. Never create or repair missing storage or waive native deletion protocol checks; preserve genuine crash replay and reject missing, noncanonical and unregistered binding authority.

Lore-id: 5879a134
Constraint: cold recovery must not initialize or repair storage
Confidence: high
Scope-risk: narrow
Reversibility: clean-revert
Tested: original crash replay cases, cold authority rejection matrix, owner cleanup/deletion/storage suites, retirement journal, package types
Not-tested: poisoned-scope timeout remediation and stale completed-summary recertification
@snowykr
fix(session): recertify exact stale cleanup completion summaries
40788fb 
A rejected fixed-name summary prevented a locked replay from publishing completion already proven by the original contiguous cleanup history. Replace only the captured stale digest summary through the existing staged exact-identity primitive; all other scope, target and owner proof fields must match. Destination swaps and replacement failure preserve uncertainty and evidence rather than replaying transcript deletion.

Lore-id: 5879a135
Constraint: stale summaries cannot authorize cleanup effects or mutation replay
Confidence: high
Scope-risk: narrow
Reversibility: clean-revert
Tested: original crash and stale-summary cases, cold authority matrix, exact replacement failure and real destination-swap cases, owner cleanup/deletion/storage/journal suites, package types
Not-tested: unchanged poisoned-scope timeout remediation and complete current hosted union
@snowykr
docs(sdk): include independently verified recovery corrections
093a987 
The complete standalone SDK layer owns the shared cold-scope and exact-summary recovery fixes. Preserve their no-repair/no-replay boundaries in the layer release notes, rather than attributing them to ACP consumer code.

Lore-id: 5879a137
Confidence: high
Scope-risk: narrow
Reversibility: clean-revert
Tested: genuine original recovery, cold authority and exact destination-race cases; diff check
@snowykr
fix(session): dispose recertification capabilities on every exit
ea5c993 
The new operation-local secured store can own a Linux recovery capability. Allocate only after strict receipt validation and pair exact replacement with explicit finally disposal; successful repair and native failure/destination-swap paths all close the exact attempted store. Borrowed-authority disposal semantics remain unchanged.

Lore-id: 5879a138
Constraint: never leak operation-owned native recovery capabilities
Confidence: high
Scope-risk: narrow
Reversibility: clean-revert
Tested: exact success/failure/swap disposal, original crash/summary cases, cold authority matrix, owner cleanup/deletion/storage/journal, package types
Not-tested: actual Linux capability ownership in local Darwin process; current hosted native gate required
@snowykr
merge(sdk): preserve current immutable retirement and exact recovery …
e5f695c 
…proof

Integrate actual dev without replaying merged P1. The named independent legacy-summary correction retains the new no-owner-effects guard while re-certifying only fresh locked completion proof; shared scope bytes match independent reference36a exactly.

Lore-id: 5879a140
Constraint: existing stale summaries cannot authorize owner effects
Confidence: high
Scope-risk: wide
Reversibility: clean-revert
Tested: retirement/resident/owner/deletion/storage, genuine cold/recovery/disposal boundaries, package types
Not-tested: complete current hosted/native/final-cohort gates; earlier failures retained
@snowykr
snowykr force-pushed the pr5879-stack-3-acp-images-d4-20261004 branch from aa511e5 to 7f58c5c Compare October 5, 2026 02:14
snowykr added 2 commits October 5, 2026 12:54
@snowykr
fix(integration): preserve current Codex replay vetoes in SDK owner
25489e8 
Retain the actual dev successor without replaying the externally merged queue layer.

Lore-id: 5879a143
Constraint: no P1 replay and no mutation replay
Confidence: high
Scope-risk: bounded
Reversibility: easy
Not-tested: current integrated SDK and hosted proof
@snowykr
fix(sdk): carry independently verified owner wire projection
bbed72d 
Apply the named independent-reference correction to the SDK-owning layer. Cleared optional fields match persisted JSON without weakening present owner evidence, and retained-scope fixtures exercise authentic scope preparation and fail-closed directory replacement.

Lore-id: 5879a144
Constraint: correction originates independent reference; no consumer-derived oracle
Confidence: high
Scope-risk: bounded
Reversibility: easy
Tested: three real broker adversarial cases and coding-agent package check
Not-tested: current full hosted Linux CI; stock Paseo browser E2E
@snowykr
snowykr force-pushed the pr5879-stack-3-acp-images-d4-20261004 branch from 7f58c5c to 58c6ee2 Compare October 5, 2026 04:05
@snowykr
merge(stack): retain durable task owners in the SDK image owner
7c84e54 
Integrate the actual dev successor after independent reference verification. Preserve existing staged image and cleanup authority while retaining durable task-owner allocation and recovery generations; the merged generic predecessor is not replayed.

Lore-id: 5879a146
Constraint: preserve existing owner wire correction and no mutation replay
Scope-risk: wide
Reversibility: revertible
Confidence: medium
Tested: independent reference owner158 and broker112 regressions; conflict-free merge and git diff --check
Not-tested: new owning SDK head full gates pending
@snowykr
snowykr force-pushed the pr5879-stack-3-acp-images-d4-20261004 branch from 58c6ee2 to d74b27c Compare October 5, 2026 06:16
@snowykr
fix(sdk): retain strict existing-transcript owner publication
8b3b366 
Propagate independently reproduced and corrected task-owner publication fencing into the SDK-owning layer. Missing transcripts remain absent and capability stays uncertain; no fallback or native security relaxation.

Lore-id: 5879a147
Tested: 53 authorization, move and task tests; package check
Not-tested: complete corrected lifecycle union and hosted platform gates
Confidence: high
Scope-risk: bounded
Reversibility: easy
@snowykr

snowykr commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator Author

Main exact-head D15 verification update, not an approval or merge authorization.

Published head d74b27c / full dispatch37271664469 completed FAILURE. All54 paginated jobs and every executed complete job log were captured with head/repository binding and hash/readback. Coding-agent shards1/2 and typescript-edit-benchmark failed, and required evidence producer/aggregate correctly failed closed. This run's Windows doctor job111639948480 succeeded; that does not erase the earlier D14 native access-denial failure or the distinct D15 SDK Windows thread-count failure, and no Windows sole cause/security waiver is claimed.

The independent D15 canonical-owner publication correction d04229f is now retained in local owning SDK8b3b3668 and complete7-commit ACP successor4de7fd72. Actual missing-transcript and pre-append unlink tests require refusal, uncertainty and unreturned-owner disposal without transcript recreation. Bounded Architect CLEAR/APPROVE closes only that publication defect; focused53-case consumer proof passed. Current corrected full lifecycle/affected/native/generated verification is running, not complete, and corrected heads are not yet published. The observed current fork/artifact regressions are being investigated separately; aggregate greens cannot substitute for these cases.

P1 #6309 is externally merged. Automatic individual ready-for-review authorization remains active, independently of final aggregate or merge authorization; no new permission or maintainer approval is being awaited solely to leave draft. P2→P3 merge order still applies. Original #5879, protected native build files and shared daemon are preserved. Stock Paseo browser E2E has not run.

snowykr added 2 commits October 6, 2026 03:41
@snowykr
fix(sdk): carry independently derived scoped terminal admission
db1b7f9 
Apply the named reference correction before consumer propagation. Preserve
its actual event/lease ownership, scoped policy readiness, final synchronous
queued admission check, and genuine terminal-before-successor evidence.

Lore-id: 5879a158
Constraint: independent reference fee7d3d remains authoritative and is not superseded by this owning-layer propagation
Constraint: preserve the 5000ms guards, SDK failure precedence, complete frame cap, and no mutation replay
Confidence: medium
Scope-risk: wide
Reversibility: revert-safe
Tested: SDK current dirty 42 promotion tests; package/diff checks; exact production and promotion-test equality to independent reference
Not-tested: SDK successor immutable complete lifecycle/platform/full hosted gates; exact already-scheduled startup-fence adverse interleaving
Directive: reference focused proof and static CLEAR do not substitute for current owning-layer execution or final stack acceptance
@snowykr
test(sdk): carry independent pre-barrier startup queue proof
483003b 
Apply the named reference test patch for actual SDK void submission, genuine
publisher ownership, intact scheduled queue resume and exact parked removal.
The independently derived reference remains separate from its SDK owner.

Lore-id: 5879a160
Constraint: do not supersede independent reference 75ecef5 or infer socket/durable delivery from local terminal chronology
Confidence: high
Scope-risk: narrow
Reversibility: revert-safe
Tested: owning SDK genuine startup resume/removal 2 tests 26 assertions; exact test and production equality to reference; diff check
Not-tested: current owning SDK immutable complete matrix and platform/hosted gates
snowykr
snowykr commented Oct 5, 2026
View reviewed changes

@snowykr snowykr left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict

CHANGES_REQUESTED

Summary

This PR adds connection-owned staged inline-image uploads and prompt consumption across ACP and SDK session hosts, with lifecycle cleanup and echo/settlement safeguards. The reviewed changes are broadly covered by targeted tests, but the runtime exposes staged-image operations to valid injected transports that cannot satisfy the new liveness check, making the feature unusable for those transports.

Findings / Required Changes

  1. [P2] Gate staged-image operations on transport liveness support — packages/coding-agent/src/sdk/host/session-runtime.ts:6832-6833
    • The new upload store treats a missing SessionSdkTransport.isConnectionOpen method as a closed connection. That method remains optional, and createSdkSessionRuntimeOptions.createTransport accepts transports that omit it. Because the runtime installs the staged-image operations whenever the store exists, a valid injected transport can start and serve ordinary controls while every staged-image begin request is rejected as resource_gone; the rest of the staged-image flow is consequently unusable on that transport. The base had no staged-image operations, so this is an incomplete implementation of the newly added feature for a transport shape the API still permits.
    • The stock WebSocket transport supplies authoritative liveness, but that guard does not apply to injected transports. Keep the fail-closed check; either require authoritative liveness for transports that expose staged-image operations or omit those operations when the transport cannot provide it. Add coverage for the no-liveness-method case.

Non-blocking Observations

  • The changed tests exercise byte-preserving upload/redemption, ownership and one-shot use, ordering/digest/MIME/expiry/quota behavior, cleanup, retry/cancel/query settlement, and the 256 KiB transport boundary. Optional boundary coverage could also demonstrate successful ACP acceptance exactly at the stated 20 MiB per-image and 64 MiB aggregate maxima; their absence is not a blocker.

CI / Verification

  • At reviewed head d74b27cf5c99202dbcf1e1c3955aad5354f1284f, the five targeted test jobs (ACP cancel settlement, ACP production path, ACP prompt terminal, SDK host wiring, and staged image upload) passed.
  • The overall Dev CI run did not pass: the affected-path evidence producer and its fail-closed aggregate failed. The job logs were inaccessible (HTTP 403), so the underlying evidence-producer failure could not be established as a product-test failure. No local tests were run during this read-only review.

Axis Coverage

Axis Verdict Coverage
A1 — Intent / Policy / Contract APPROVED Registry restrictions and image payload/lifecycle contract align with the inspected SDK policy; no material reuse or intent mismatch found.
A2 — Architecture / Correctness / Failure CHANGES_REQUESTED Finding 1: valid injected transports may omit the optional liveness method, leaving the advertised staged-image operations installed but unusable.
A3 — Security / Privacy / Trust APPROVED Connection ownership, liveness, bounded payload validation, one-shot redemption, and cleanup preserve the inspected trust boundaries.
A4 — Verification / Tests / CI APPROVED Targeted PR-head test jobs passed; the separate evidence-producer/aggregate failure remains unexplained and is not established as a product defect.
A5 — Context / Compatibility / Platform CHANGES_REQUESTED Finding 1: injected-transport integration is inconsistent with the still-optional transport contract; the built-in WebSocket implementation does not cover custom transports.

Limitations

No PR-associated intent_projection was available. CI job logs returned HTTP 403, so the cause of the evidence-producer failure and branch-protection requiredness could not be verified. The review did not execute tests or PR code.

snowykr added 5 commits October 6, 2026 05:57
@snowykr
fix(sdk): retain image ownership through durable queued teardown
ffed105 
Integrate actual D20 only after its independent reference composition. Apply
named source-resolution and authentic lifecycle-fixture patches from reference
1150a4a, preserving the owning SDK test residuals and complete upstream changes.

SDK source and semantic daemon manifest equal the independent reference;
generation 203 replaces both overlapping generation-202 owners. Root-priority
coverage keeps actual void SDK dispatch and authentic ExtensionRunner tokens.

Lore-id: 5879a162
Constraint: independent reference remains authoritative; no inverse ACP copy
Directive: preserve awaited removal publication, uncertainty and image release
Confidence: medium
Scope-risk: wide
Reversibility: easy
Tested: focused authentic root/successor projection, package, current manifest, diff
Not-tested: immutable full SDK/ACP matrices, platform, combined image shutdown faults, browser, final cohort
@snowykr
test(sdk): propagate the combined daemon generation fixture
f1d6329 
Unrestricted reference-to-stack comparison caught the generation-202 fixture
left behind when applying the four-file SDK source-resolution patch. Apply the
independent generation-203 fixture patch before immutable stack qualification;
no runtime source or daemon state changes in this correction.

Lore-id: 5879a163
Constraint: generation source, semantic manifest and fixture must travel together
Confidence: high
Scope-risk: narrow
Reversibility: easy
Tested: complete notifications topic-registry file and diff checks
Not-tested: immutable full stack, hosted/platform/native/browser acceptance
@snowykr
test(sdk): retain rejecting foreign-root seam and original wiring budget
73cdf58 
Unrestricted residual review found a success-shaped forbidden foreign-root seam
and an outer timeout increase absent from the independent reference. Restore
both reference contracts without changing production behavior or inner guards.

Lore-id: 5879a164
Constraint: original 500ms lease, 350ms progress, 5000ms runtime and 15000ms monotonic wait remain
Constraint: independently constructed reference 1150a4a is the correction authority
Confidence: high
Scope-risk: narrow
Reversibility: easy
Tested: generic queued ownership ordinary/terminal 2 pass 39 assertions
Tested: original default-budget stop/restart ownership 1 pass 20 assertions
Not-tested: complete current-head matrices and hosted/native final gates
Directive: no fabricated terminal evidence for forbidden foreign-root calls
@snowykr
docs(sdk): retain independent queued-image and requester release cont…
bf123be 
…racts

The owning SDK fragment already carries host, budgets, expiry and shared fixes.
Carry the independent combined fragment's exact queue/image lifecycle and
requester-abort bullets as well, rather than relying on broad budget wording.

Lore-id: 5879a165
Constraint: each independent release bullet travels with its source owner
Confidence: high
Scope-risk: narrow
Reversibility: easy
Tested: exact four SDK bullets read against independent reference 1150a4a
Tested: git diff --check
Not-tested: fresh full current-head runtime, hosted and final quality gates
@snowykr
test(sdk): carry independent combined image teardown fault proof
bd71fb4 
Apply the named full-index correction from independently committed reference
a2e5e2c. Preserve all text and image cases, actual reservations and release
closures, durable failure uncertainty and the forbidden-root diagnostic seam.

Lore-id: 5879a168
Constraint: reference-first patch e7c643688d088c4671a7695c5c8b8dcc0254fbb0f0b81e2bfdaa57fa8ed15fa0
Confidence: high
Scope-risk: narrow
Reversibility: easy
Tested: owning text/image teardown matrix 10 pass 249 assertions and package check
Not-tested: current-head complete matrices, both hosts, public capacity threshold and browser E2E
Directive: controlled method-observable release is not wire or durable publication proof
@snowykr
snowykr force-pushed the pr5879-stack-3-acp-images-d4-20261004 branch from d74b27c to c76ab3d Compare October 6, 2026 02:31
@snowykr

snowykr commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

Published the existing draft PR at exact head c76ab3de8c2a5fdee4a6bb4133229b7bea011d23 after the Mac-to-Linux continuation. The previous remote head was preserved locally and publication used an exact-old-head lease; original PR #5879 was not modified.

Full nonpublishing CI is explicitly dispatched with rehearsal=main-nontag: https://github.com/Yeachan-Heo/gajae-code/actions/runs/37404855018 (API verified exact head, repository and workflow_dispatch). This is additional to the automatic affected-path Dev CI; no green or complete job/log inspection is claimed yet.

Current SDK/ACP/reference commits, cumulative versus marginal sizes, retained historical failures and scoped Linux test evidence are in the updated PR body. The earlier body remains verbatim in a clearly historical collapsed section. SDK/host-wiring failures remain an open blocker; isolated diagnostic greens do not erase them. Draft/Ready and merge decisions remain gated separately.

Agent review — advisory source semantics only: complete independent-reference versus ACP tracked trees retain exactly six extraction-only residuals with no exclusions. Three test residuals and the split release-bullet mapping were reviewed; the failed-publication retirement clause was restored. The held-upload test observation correction was independently authored/reviewed in reference 297f898df4054d3309086ff6ea68051e00b2e4a9 and then propagated to ACP. Current ACP watchdog: 53 passed / 263 assertions; actual saved-ID fork/session-ID suite: 21 passed / 83 assertions. No product, test deadline or cancellation guard was relaxed. This is not a write-access maintainer approval, frozen final cohort, native checkpoint, hosted-CI pass or merge authorization.

@snowykr
fix(sdk): propagate independently reviewed pure image limits
ffba6ff 
Apply the shared SDK portion of reference d02bc74 without borrowing ACP-only consumer changes. Numeric limits and enforcement stay identical; machine-safe policy no longer imports operational image loaders.

Lore-id: 198c52be
Constraint: independent reference correction precedes named SDK propagation
Confidence: high
Scope-risk: narrow
Reversibility: easy
Tested: exact shared source blobs match independently verified reference policy
Not-tested: new SDK full source-head verification chain
@snowykr
snowykr force-pushed the pr5879-stack-3-acp-images-d4-20261004 branch from c76ab3d to 5301d8d Compare October 6, 2026 04:52
snowykr added 12 commits October 6, 2026 05:13
@snowykr
fix(session): keep public terminal settlement independent of extensions
4296ce7 
The SDK stack added a second unconditional extension-delivery await after publication. It made ordinary public prompt and idle settlement wait on a blocked extension, unlike immutable dev. Remove only that redundant await; SDK-owned delivery still joins its inner extension await and producer discovery still closes after actual delivery.

Lore-id: 5879-public-end-barrier
Constraint: retain SDK extension ordering and deferred producer-lease release
Confidence: high
Scope-risk: narrow
Reversibility: revert-clean
Tested: reference message pipeline 25 pass; original public and shutdown cases pass
Not-tested: exact successor full lifecycle union; SDK worker checkpoint remains unresolved
@snowykr
feat(acp): stage inline prompt images through authenticated SDK uploads
e6d203a 
ACP must preserve original image bytes without enlarging private SDK frames. Add the complete consumer path with staging-before-echo, upload-progress watchdogs, request-owned cancellation and confirmed-retirement retries.

Lore-id: 5879a107
Constraint: keep full frames at 256KiB and preserve exact bytes, MIME and request ownership
Confidence: high
Scope-risk: cross-layer
Reversibility: easy
Tested: ACP conformance, watchdog, terminal, production path, adapter, reconnect, two-client race and disposition suites; package Biome and TypeScript checks
Not-tested: stock Paseo browser E2E and hosted CI on the new stack
Directive: upper PR depends on the complete SDK layer and remains a native draft until its predecessor is verified on dev
@snowykr
fix(acp): retain cancelled echo barriers across session replacement
07a4499 
A pending user-image publication outlives its SDK attachment. Record-local fences let a replacement publish successor work first, and retired-adapter deadlines could not fail the new owner. Keep pending and failed publication ownership at the session boundary until success or explicit retirement.

Lore-id: 5879a108
Constraint: retain original bytes and request-local cancellation without host abort or replay
Confidence: high
Scope-risk: cross-layer
Reversibility: easy
Tested: real same-ID replacement red/green probe; watchdog45; terminal167; production7; conformance2; package checks
Not-tested: stock Paseo browser E2E and hosted stack CI
Directive: preserve immutable F/R2 and independently apply this named AC10 correction to the unsplit reference
@snowykr
docs(sdk): retain identical independent cancellation guidance
4f37ecd 
Keep the reviewed current-dev reference wording and complete staging contracts during the layered documentation merge. Remove only an extra blank line introduced at the section join.

Lore-id: 5879a113
Confidence: high
Scope-risk: narrow
Reversibility: easy
Tested: unrestricted documentation diff against pinned independent reference is empty
@snowykr
test(acp): assert local provider-preflight cancellation has no remote…
c0e39c6 
… abort

Provider preflight has not dispatched a prompt. Its cancellation completes
locally rather than borrowing a remote abort acknowledgement. Replace the
obsolete rejection expectation with actual no-dispatch/no-abort assertions.

Lore-id: 5879a115
Constraint: do not weaken acknowledged or uncertain remote abort contracts
Confidence: high
Scope-risk: narrow
Reversibility: easy
Tested: complete ACP cancellation settlement suite 59 cases, 388 assertions
Not-tested: hosted CI on the successor stack; stock Paseo browser E2E
@snowykr
test(acp): verify dispatch observer before uncertain reply recovery
0cb96cb 
The prompt API now forwards dispatch observers, so the old assertion that router options are absent intercepted the intended uncertain-after-send failure. Exercise an explicit observer at the original connection/generation boundary and retain every original clientRef, session-bound recovery and no-mutation-replay assertion.

Lore-id: 5879a120
Constraint: keep original clientRef and consuming attachment after uncertain send; no mutation replay
Confidence: high
Scope-risk: narrow
Reversibility: clean
Tested: authentic obsolete-contract RED; all four reconnect cases GREEN; package check
Not-tested: real browser E2E and final hosted/frozen approval
@snowykr
docs(sdk): retain merged generic guarantees in the complete ACP layer
fc2b6f5 
Preserve requester snapshots, retired queue authority, exact joined teardown and durable uncertainty alongside image capacity ownership. Match the independently reconciled full-feature reference without weakening the consumer staging boundary.

Lore-id: 5879a125
Confidence: high
Scope-risk: narrow
Reversibility: clean-revert
Tested: reconnect suite, real owner-clock case and package check
@snowykr
test(acp): retain acknowledged cancel while awaiting real terminal
c365e5a 
The merged ACP baseline makes acknowledged cancellation own the stopped reason. Preserve the genuine grace-period terminal requirement: acknowledgement alone leaves the prompt pending, and a real stopped frame settles cancelled rather than a stale refusal reason. Keep original grace and wait budgets unchanged.

Lore-id: 5879a130
Constraint: acknowledgement is not a fabricated execution terminal
Confidence: high
Scope-risk: narrow
Reversibility: clean-revert
Tested: complete ACP prompt-terminal suite and package check
@snowykr
docs(acp): preserve large-inline and exact watchdog release contracts
20b9fb4 
Carry the independent combined fragment's larger-than-frame/no-Paseo-upload
and request-owned watchdog guarantees in the ACP consumer fragment, without
expanding staging-before-echo into a model or admission success guarantee.

Lore-id: 5879a166
Constraint: original bytes, MIME and 256KiB complete private frame cap remain unchanged
Confidence: high
Scope-risk: narrow
Reversibility: easy
Tested: consumer bullets mapped to independent reference 1150a4a
Tested: git diff --check
Not-tested: fresh full immutable ACP/reference/SDK matrices and final hosted gates
@snowykr
docs(acp): retain failed publication lifetime in split release note
6ba736b 
The split ACP fragment dropped the original failed-publication retention condition. Restore the explicit retirement boundary without changing product behavior or the independent reference.

Lore-id: 2c4e52d9
Constraint: preserve the original PR5879 publication barrier contract
Confidence: high
Scope-risk: narrow
Reversibility: easy
Tested: five same-ID replacement regressions passed with 38 assertions
Not-tested: full ACP successor verification matrix
@snowykr
test(acp): join held upload response before observing cleanup
fe780d9 
The cancellation fixture observed an initially empty upload set before a held begin had allocated its late resource. Join the real controlled response before checking retirement, retaining the existing cancellation assertions and test deadlines.

Lore-id: e981d7ba
Constraint: preserve original cancellation guards and independent reference provenance
Confidence: high
Scope-risk: narrow
Reversibility: easy
Tested: full watchdog suite 53 passed with 263 assertions
Tested: package type and lint checks passed with existing diagnostics visible
Not-tested: remaining SDK host wiring failures
@snowykr
fix(acp): consume pure image limits without session tooling imports
9d2e9f9 
Apply the ACP-only part of independently reviewed reference d02bc74 on the corrected SDK owner. Preserve inline-image size accounting and all admission behavior while removing the forbidden transitive loader path.

Lore-id: 348210ce
Constraint: keep exact SDK owner as an ancestor
Confidence: high
Scope-risk: narrow
Reversibility: easy
Tested: import and shared policy blobs match independently verified reference
Not-tested: current rebased ACP complete lifecycle and hosted gates
@snowykr
snowykr force-pushed the pr5879-stack-3-acp-images-d4-20261004 branch from 5301d8d to 9d2e9f9 Compare October 6, 2026 05:29
@Yeachan-Heo

Yeachan-Heo commented Oct 7, 2026

Copy link
Copy Markdown
Owner

This PR is being closed because:

  1. Author Status: Explicitly marked DRAFT / NOT READY / NOT MERGE-APPROVED in the PR body
  2. Review Status: CHANGES_REQUESTED findings that require implementation
  3. Stack Dependencies: Part of a PR stack (feat(sdk): stage lossless authenticated images across both hosts [5879 stack 2/3] #6310) which is also not merge-ready
  4. Merge Conflicts: Significant conflicts on rebase to origin/dev indicating incomplete refactoring
  5. CI Blockers: Multiple documented blockers about missing hosted matrix validation and lifecycle tests

Per the repo's development workflow, this PR should be reopened when:

The work can be resumed by reopening this PR or creating a new one when the above conditions are met.

—
[repo owner's gaebal-gajae (clawdbot) 🦞]

@Yeachan-Heo Yeachan-Heo closed this Oct 7, 2026
@snowykr

snowykr commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

Closure comment inspected. #6309 is already merged; #6310 and #6311 are closed, unmerged. No reopen or Ready claim is being made prematurely.

Current unpublished successors are SDK 9fc4d87edebe8696b4871245d1bf428cdf86184a and ACP 63e9c0c11b7a0a97a3678c83e16c64e4f5c9ca8b, composed with pinned accepted dev de2a916. The historical custom-transport liveness finding is CONFIRMED STILL OPEN on current SDK source: SessionSdkTransport.isConnectionOpen remains optional at line353, while the upload store treats its absence as false at line6934. It is not closed by earlier targeted greens or composition reviews.

Current independently bound Linux evidence: all three owners passed whole memory107/838, genuine saved-ID fork49/250 and genuine TTL3/9; ACP original59-file manifest has57 unskipped passes and2 skipped commands, not full acceptance. ACP whole SDK runtime passed251/3634. Reference and SDK complete runtime each retain one captured-cancel boundary assertion failure, with cause unresolved. Remaining original SDK/reference matrices are executing with prior failed receipts retained rather than retried. Independent reference native build child exited0; committed/working closure and copied output readbacks were verified separately from the monitor status.

Historical failures, Windows/full hosted/native/cohort obligations and review findings remain distinct. The published old PR heads are not these local successors. No fresh hosted CI, maintainer approval, merge, complete aggregate or reopen readiness is claimed.

@snowykr

snowykr commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

The confirmed transport-liveness finding now has a local, independently reviewed repair: reference commit 5dededa6196f4c3430b95064706e71f01fc1e76c (tree71f5a2cdfbee718f04338377e1fb4dae704b8db2), based on accepted-dev composition8eaec7b0. It is NOT yet propagated to the SDK/ACP successors or published to these closed PR heads.

The optional transport method remains optional for text-only consumers, but absent authoritative membership now means no image store, no advertised/installed turn.image controls, and explicit staged-reference rejection. Supported methods retain their transport receiver and connection-owned per-operation checks. No frame-observer membership fallback was added.

Architect39 gave bounded CLEAR/APPROVE for the exact two-file source/test delta, with independent Git blob readbacks. Exact committed repair reference gates passed: new injected-transport regressions2/11, complete image-upload31/3583, surface parity5/27, package/type check0. Earlier new-test envelope mistakes and missing generated-doc index errors remain preserved in separate receipts, not relabeled greens.

Whole-file readiness remains blocked: the latest corrected253-case runtime execution retained252pass/1 original repeated-agent_failed diagnostic30000ms timeout. Prior SDK/reference captured-cancel reds, SDKhost-wiring5000ms timeout with cleanup ENOENT, currentG002 failure, Windows/full-hosted/cohort/native obligations remain unwaived. Original SDK matrix execution is currently incomplete52/59 with3 retained reds; it is not represented as completed acceptance. No reopen/Ready/push/maintainer-approval/aggregate claim.

@snowykr

snowykr commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

Continuation update — local, unpublished, NOT READY / NOT MERGE-APPROVED.

The optional-transport review finding is committed and propagated locally: reference cc5f3f679, SDK 0442e86fc, ACP 9915bc283. Missing authoritative liveness omits image storage, advertised operations and installed image controls; text remains available and staged references reject. Supported transports retain receiver-bound authoritative checks.

The exact remaining-budget test snapshots now use a local pinned wall clock, separate from genuine unchanged 2000ms polling. All three committed adapter suites pass: 42 tests / 164 assertions; package checks pass. Production lifecycle deadlines were not reset or inflated.

On these exact local heads, SDK and ACP each pass the complete runtime (253 tests / 3645 assertions), host wiring (158 / 1191), and pipeline (35 / 119). Reference runtime retains a 30000ms timeout in stalled 402/429 branch drainage (252 pass / 1 fail); reference host wiring and pipeline pass. This is not failure-cause proof or a waiver of earlier reds.

All original 59-command de2 predecessor matrices are now complete, preserving interrupted receipts and never replaying completed failures: SDK 54 pass / 3 failed / 2 skipped commands; reference 54 / 3 / 2; ACP 57 / 0 / 2. All 177 receipts and 354 logs were hash-audited. Skipped commands are not acceptance, and predecessor matrices are not new-head acceptance.

Fresh remote inspection shows #6310 was externally reopened as Draft at 0667ec2e5 with its own transport fix. That published user work has not been overwritten. Latest dev 95cd0ae1c was pinned read-only; these local verified owners remain de2-based, not current-base hosted candidates.

#6311 remains closed: original closure conditions, retained runtime red, inherited G002/default-MCP discovery boundary, current full lifecycle/fork/consumer/adversarial union, Windows/hosted/native-final and joined final-cohort obligations are not discharged. No push, Ready conversion, merge or maintainer approval is claimed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yeachan-Heo Yeachan-Heo Awaiting requested review from Yeachan-Heo Yeachan-Heo will be requested when the pull request is marked ready for review Yeachan-Heo is a code owner
@probepark probepark Awaiting requested review from probepark probepark will be requested when the pull request is marked ready for review probepark is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@snowykr @Yeachan-Heo