Repository navigation
Conversation
Session close revokes the ready marker but keeps lifecycle.json until session.delete. Update the topology assertion to match the existing lifecycle contract.
Owner
|
#6287 and #6294 make the same one-line change to — |
Owner
|
Closing as a duplicate: #6287 made the same one-line change and is merged into dev as — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6289
Risk classification
low-risk— test-only, one-line assertion correction; no runtime code touched.regression-riskhigh-riskWhy
session.closerevokes the lifecycle ready marker while retaininglifecycle.jsonuntilsession.delete. The topology test still expectedlifecycle.ready.jsonto resolve, producing a stale assertion failure.What
Changed only
packages/coding-agent/test/sdk-machine-lifecycle-topology.test.tsso the post-close ready-marker assertion expects rejection. The lifecycle-marker-retained assertion and post-delete cleanup verification remain unchanged.Local tests
bun test packages/coding-agent/test/sdk-machine-lifecycle-topology.test.ts(before change: exit 1, 6 pass / 1 fail, failure at line 641; after change: exit 0, 7 pass / 0 fail, 462 expects)bunx biome lint packages/coding-agent/test/sdk-machine-lifecycle-topology.test.ts(exit 0)bun --cwd=packages/coding-agent run lint(exit 0; 2 pre-existing warnings and 1 info)bun run lint(exit 0; Rust future-incompatibility warnings only)Local CI gate (prepush)
bun run check(exit 1, BLOCKED by unrelated existing failure inpackages/coding-agent/test/sdk-adapter-dispositions-daemon-cli.test.ts,AD-L-C49: session.cwd.move forwarded; 100 pass / 1 fail in that manifest; Rust checks passed)scripts/or package configuration, so no checker command was available to run.Needs e2e
None outside CI. The broker lifecycle suite was run locally at exact head
aa743a32(coder re-verification on studio, afterbun run setup:worktree):bun test packages/coding-agent/test/sdk-machine-lifecycle-topology.test.ts→ exit 0, 7 pass / 0 fail, 462 expectsbun test packages/coding-agent/test/sdk-broker-lifecycle-e2e.test.ts→ exit 0, 152 pass / 1 skip / 0 fail, 765 expectsAcceptance
session.closeretainslifecycle.jsonand removesready.jsonin both adapter directionsmcp → daemonanddaemon → mcpruns (7/7)session.deleteremoves the lifecycle marker without cross-workspace effectsAgent
GJC, preset
codex-pro.Assumptions
probepark:fix-6289-t91e2d399is the authorized source branch for a PR targeting upstreamdev.bun run checkfailure is pre-existing and outside this one-line test-only scope.Open questions
Approval
Review verdict: human-review pending (no
gajae.pr-review-verdict.v1line yet).Agent PR Merge approval red is expected pending maintainer exact-head approval. Human review remains required on the exact PR head.