Skip to content

fix(natives): prepare strict native checks for task admission stack - #6277

Merged
Yeachan-Heo merged 1 commit into
devfrom
fix/task-stack-01-native
Oct 3, 2026
Merged

Yeachan-Heo merged 1 commit into
devfrom
fix/task-stack-01-native

Conversation

@snowykr

@snowykr snowykr commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator

Task admission stack — 01: native verification prerequisite

Independent prerequisite to split #6240 into safe reviewable changes. This PR does not activate task admission changes or managed task owners. Later layers are prepared separately; #6240/reference remain unchanged.

Change

  • Rename the macOS acquisition-policy binding read by the repairable-write fallback so strict Clippy accepts it; explicitly discard it on non-macOS builds.
  • Regenerate the 0.18.5 diagnostic-artifact record from the genuine rebuilt 115-export addon. No readonly acquisition, security or version/digest validation is relaxed.

Size and independence

  • Production added+deleted: 10 lines (native source6, diagnostic record4), relative to parent/dev integration base 2a97f5fa2cddc69ea30b097ebdf823977a044fa6.
  • Changelog is separate; no test/fixture exclusion is needed to hide code size.
  • Complete standalone fix; no stubs, feature flags, compatibility aliases, owner schema publication or GC/SDK/task activation.

Actual verification

Actual approved/merged PR head: b7fafa1afafef065a587049f2cec9178cd60075a. GitHub records approval by probepark on this exact head and external merge by Yeachan-Heo at 2026-10-03T14:51:34Z, merge commit 8de425edbf16d8e0fa3ea82553929d8860168f4d. The leader did not perform the merge. Later prepared current-dev branch ecf525bdd… was requalified and pushed during this external transition, but it is not this PR's merged/reviewed head; all three native files are byte-identical between the two commits. No approval is transferred between heads. Original b7f qualification is retained below; later ecf proof is separate historical stack integration evidence.

  • bun run build:native: genuine addon/provenance regenerated, 115 exports.
  • bun test packages/coding-agent/test/notifications-compiled-daemon-smoke.test.ts packages/natives/test/path-identity-posix.test.ts: 35 passed, 0 failed, 141 assertions.
  • bun run check:rs in exact detached nonnested QA /private/tmp/gjc-task-stack-native-qa at this commit: passed (Rust scope, cargo fmt check, workspace Clippy -D warnings).
  • git diff --check: passed.
  • Existing nix future-incompatibility warnings retained. Linux/Windows native runtime not tested on this Darwin host; CI results are separate, not presumed green.

Delivery

Targets dev. The observed external merge/approval above is reported, not a leader-performed merge or approval of another head. Dependent stack layers must obey dev-base policy and their actual dev diff budget; a small parent-relative layer is never advertised as a small dev PR. Protected44-staged worktree and verified #6240 head remain untouched.

The existing macOS policy branch reads an underscore-prefixed binding,
which strict Clippy rejects. Preserve the acquisition policy and bind
fresh diagnostic provenance to the genuine rebuilt addon.

Lore-id: 95d234a1
Constraint: do not relax readonly acquisition or artifact validation
Confidence: high
Scope-risk: narrow
Reversibility: easy
Tested: 35 native path-identity and compiled-daemon tests, 141 assertions
Not-tested: Linux and Windows native runtime on this host
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@probepark probepark left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (head b7fafa1, gajae-reviewer on behalf of probepark)

CI: green — 0 pending / 0 failed at this head (4 skipped opt-in/Windows/live-release jobs); approve gate ALLOW, check:@gajae-code/natives covered.
Scope: +9 / -4, 3 files — crates/pi-natives (path_identity.rs), packages/natives (diagnostic-artifact.json, changelog.d fragment)
Conventions: changelog.d fragment present (packages/natives/changelog.d/task-admission-stack-native-prerequisite.md), no released CHANGELOG section touched, no hand-edited generated files (models.json/schemas/docs-index), no labels.
Notable:

  • crates/pi-natives/src/path_identity.rs:2890-2893 — _policy → policy with #[cfg(not(target_os = "macos"))] let _ = policy;. The only consumer is the macOS-only EACCES retry at :2988, so on macOS the binding is now read without the leading-underscore used_underscore_binding lint, and on other targets it is explicitly discarded. Pure rename; no change to behaviour or to the ReadOnly/RepairableWrite gate.
  • packages/natives/native/diagnostic-artifact.json — version 0.17.7 → 0.18.5 matches packages/natives/package.json at base 2a97f5f (0.18.5). The darwin-arm64 sha256 comes from the author's local build:native and cannot be reproduced on Linux CI; no CI check on this head failed because of it.
    Blocking: none

Body verdict line: none in PR body (count=0); not edited. Suggested verdict line: gajae.pr-review-verdict.v1 merge-approved sha256:bbf5098ad276621b8468184c3d7fb10f068c06afbc604524d56169c82d1d78aa reviewer:human reviewer-id:probepark evidence:ci-green;approve-gate-allow;natives-check-covered;rename-only-cfg-gated;artifact-version-matches-package

Verdict: gajae.pr-review-verdict.v1 merge-approved sha256:bbf5098ad276621b8468184c3d7fb10f068c06afbc604524d56169c82d1d78aa reviewer:human reviewer-id:probepark evidence:ci-green;approve-gate-allow;natives-check-covered;rename-only-cfg-gated;artifact-version-matches-package

@Yeachan-Heo
Yeachan-Heo merged commit 8de425e into dev Oct 3, 2026
29 checks passed
@Yeachan-Heo

Copy link
Copy Markdown
Owner

Merged into dev.

—
[repo owner's gaebal-gajae (clawdbot) 🦞]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants