Repository navigation
fix(task): renew admission scope after committed session moves #6240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
snowykr
wants to merge
5
commits into
dev
Choose a base branch
from
fix/task-admission-after-session-move
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,668
−163
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
373ad0b
fix(task): renew admission authority after committed session moves
snowykr 3a2bec8
fix(task): publish readonly target settings and resource metadata
snowykr 93bf930
fix(task): preserve scope and artifact ownership across moves
d122494
fix(task): preflight async authorization and preserve queued scope
c1bad03
fix(session): close superseded artifact manager store and add lifecyc…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
packages/coding-agent/changelog.d/task-admission-after-session-move.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ### Fixed | ||
|
|
||
| - Allow new tasks to use the committed target repository after an authorized session move, including previously materialized task tools, while preserving admitted tasks' execution scope, repository checks, and output ownership. |
3 changes: 3 additions & 0 deletions
3
packages/coding-agent/changelog.d/task-artifact-owner-lifecycle.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ### Fixed | ||
|
|
||
| - Close the superseded session-scoped artifact manager's store when transitioning to a managed task artifact owner, preventing retention of derived authorities and ensuring proper lifecycle management. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When templates are discovered automatically and a session moves from A to B, this assignment updates only the task-facing
toolSession; theAgentSessionretains the A templates supplied during construction in its private#promptTemplatesarray. Consequently, subsequent parentprompt(),steer(), orfollowUp()calls that expand a template can still inject A's repository-specific template even though new tasks use B's template. Add a live-session template replacement path and update both registries after discovery.Useful? React with 👍 / 👎.