Fix memory/graph bugs and wire up Knowledge Pulse#2
Merged
Conversation
- Fix /analyze/memory returning 500 instead of 400 for empty text
(the validation HTTPException was being caught by the generic
exception handler and re-raised as a 500)
- Fix relationship confidence of 0 being silently overwritten by
the 0.9 default (|| -> ??)
- Fix query_memory tool results never reaching setRetrievedMemories:
the frontend expected the whole tool result to be an array, but it
was always {tool, output, success}; results now come through a
dedicated `memories` field
- Render <KnowledgePulse /> in AppShell instead of its old inline
"Knowledge Context" panel, so the memory-confidence UI is reachable
Note: this branch does not reintroduce the Python intelligence-layer
call into storeMemory (entities/relationships/graph-activity stay
empty in the panel). That call was removed by later upstream commits
(multi-tenant workspace isolation / hardening), and re-adding a
synchronous external HTTP call to every memory write should be a
deliberate follow-up decision, not bundled into a bug-fix branch.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Yashasm18
force-pushed
the
fix/knowledge-pulse-wiring-and-bugs
branch
from
July 14, 2026 03:45
d1281f2 to
f9b0f6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/analyze/memoryreturning 500 instead of 400 for empty text (validation error was being caught by the generic exception handler and re-raised)0being silently overwritten by the0.9default (||→??)query_memorytool results never reachingsetRetrievedMemories(frontend expected the whole tool result to be an array; results now come through a dedicatedmemoriesfield)<KnowledgePulse />inAppShellinstead of its old inline "Knowledge Context" panel, so the memory-confidence UI is actually reachableNote on scope
This branch was originally going to fully wire entities/relationships/graph-activity into the Knowledge Pulse panel via the Python intelligence layer, but that call was removed from
storeMemoryby later commits onmain(multi-tenant workspace isolation / hardening work). Re-adding a synchronous external HTTP call to every memory write is a deliberate architecture decision, not something to bundle into a bug-fix PR — so those panel sections remain present but empty for now.Test plan
tsc --noEmitonapps/web— clean (only pre-existing, unrelated stale.nexttype errors remain)🤖 Generated with Claude Code