[XRT-SMI] AIESW-28055 fix. xrt-smi examine --advanced should behave similar to xrt-smi examine#9718
Open
aktondak wants to merge 2 commits intoXilinx:masterfrom
Open
[XRT-SMI] AIESW-28055 fix. xrt-smi examine --advanced should behave similar to xrt-smi examine#9718aktondak wants to merge 2 commits intoXilinx:masterfrom
aktondak wants to merge 2 commits intoXilinx:masterfrom
Conversation
Signed-off-by: Akshay Tondak <Akshay.Tondak@amd.com>
aktondak
requested review from
AShivangi,
chvamshi-xilinx,
rozumx and
stsoe
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
This PR fixes the behavior of xrt-smi examine --advanced command. Currently this command printed help as if the command usage was incorrect. This should be a valid command and should behave exactly how xrt-smi examine would behave.
This PR also fixes a speculative bug identified by claude where some smi APIs were changing the singleton object. This mutation of singleton objects should be under a lock guard so that no multiple threads can alter the singleton.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Solved via removing the unnecessary if guard for XBU::getAdvance() when running xrt-smi examine
Risks (if any) associated the changes in the commit
None
What has been tested and how, request additional testing if necessary
Tested on windows platform.
Documentation impact (if any)
None