Update XRT to use aie_codegen for XDP client flow#9712
Closed
snigdha-gupta wants to merge 8 commits intoXilinx:masterfrom
Closed
Update XRT to use aie_codegen for XDP client flow#9712snigdha-gupta wants to merge 8 commits intoXilinx:masterfrom
snigdha-gupta wants to merge 8 commits intoXilinx:masterfrom
Conversation
Signed-off-by: snigupta <snigupta@amd.com>
Signed-off-by: snigupta <snigupta@amd.com>
Signed-off-by: snigupta <snigupta@amd.com> Signed-off-by: Gupta <snigupta@amd.com>
Signed-off-by: snigupta <snigupta@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: snigupta <snigupta@amd.com>
snigdha-gupta
force-pushed
the
xrt_client_aie_codegen
branch
from
e473de0 to
7725688
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
- Extend aie-rt/src build condition to include XDP_VE2_BUILD_CMAKE alongside XRT_NPU (both Linux and Windows blocks) - Add aie-rt/fal subdirectory and set AIEFAL_DIR for VE2 builds so _xdna plugins can find xaiefal headers Signed-off-by: snigupta <snigupta@amd.com> Made-with: Cursor
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
VE2 is an Edge build (XRT_EDGE=1), so the aie-rt/src and aie-rt/fal subdirectories were never added. Move the VE2 block outside the if(NOT XRT_EDGE) guard so aie_codegen and FAL are built for VE2 Edge builds. NPU (non-Edge) path remains inside the guard. Signed-off-by: snigupta <snigupta@amd.com> Made-with: Cursor
Signed-off-by: snigupta <snigupta@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
aie-rt is being replaced by aie-codegen , which is why XDP is moving over to aie-codegen as well
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
N/A
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Client (strix)
Documentation impact (if any)