[VITIS-15472] Add io_uring changes to adf_runtime_api.cpp files#9708
Open
ManojTakasi wants to merge 1 commit intoXilinx:masterfrom
Open
[VITIS-15472] Add io_uring changes to adf_runtime_api.cpp files#9708ManojTakasi wants to merge 1 commit intoXilinx:masterfrom
ManojTakasi wants to merge 1 commit intoXilinx:masterfrom
Conversation
Signed-off-by: Takasi, Manoj <Manoj.Takasi@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Adds an optional io_uring-style async path for GMIO shim BD enqueue on edge AIE.
when enabled, BD programming uses XAie_DmaWriteBdAsync and queueing uses XAie_DmaChannelPushBdToQueueAsync, with completion handled via XAie_AsyncWaitNr, instead of the synchronous XAie_DmaWriteBd / XAie_DmaChannelPushBdToQueue sequence. This is intended to improve throughput when the AI Engine driver stack supports these async entry points.
Waiting for io_uring changes to be merged in the aie-rt repo. After that, we can merge this PR.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
his is a performance enhancement
How problem was solved, alternative solutions (if any) and why they were rejected
Plumb an io_uring flag through config_manager and in gmio_api::enqueueBD
async path builds the same BD fields as before, then submits with the async APIs and waits/errors consistently via a small helper around XAie_AsyncWaitNr.
Risks (if any) associated the changes in the commit
low
What has been tested and how, request additional testing if necessary
Tested on vck190 hw emulation by generating and installing the xrt package
Documentation impact (if any)
Yes. I will update the document once this PR is merged.