fix: restore previous spawnRef binding on finalizer cleanup#1416
Merged
Conversation
When Actor.layer is initialized more than once in the same process (memo'd ManagedRuntimes, overlapping test runtimes), the inner scope's finalizer was wiping spawnRef to undefined, breaking every subsequent tryStartCheckpointWriter call. Save and restore the previous binding instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spawnReffinalizer to restore the previous binding instead of wiping toundefinedtryStartCheckpointWriterwhenActor.layeris initialized more than once in the same process (memo'd ManagedRuntimes, overlapping test runtimes)Actor.layerChanges
src/actor/spawn.ts: SaveprevSpawnRefbefore overwriting and restore it in the finalizertest/session/checkpoint-*.test.ts: Apply matching fix to test actor mockstest/tool/actor.test.ts: Save/restorespawnRefinbeforeAll/afterEachinstead of setting toundefined