fix(test): settle fake checkpoint writer so main-slice test drains cleanly#1400
Open
onlyfeng wants to merge 1 commit into
Open
fix(test): settle fake checkpoint writer so main-slice test drains cleanly#1400onlyfeng wants to merge 1 commit into
onlyfeng wants to merge 1 commit into
Conversation
f43ba9e to
efcf6bc
Compare
…eanly The recording actor's spawn outcome never resolved, so tryStartCheckpointWriter's settlement-watcher fiber stayed suspended and was force-interrupted at scope close — a flaky source under it.live. Settle the outcome so the watcher runs to completion (writers.delete) and assert the writer drains to "no-writer". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
efcf6bc to
946b80b
Compare
Contributor
Author
|
Note for reviewers — the failing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkpoint-main-slicetest: the recording actor's spawn outcome never resolved,leaving
tryStartCheckpointWriter's settlement-watcher fiber suspended until scopeclose force-interrupted it — a flaky source under
it.live. Settle the outcome sothe watcher completes (
writers.delete) and assert the writer drains tono-writer.No production change —
actor/spawn.tsis untouched; the test's spawn-ref finalizerstays
= undefined, consistent with the sibling checkpoint tests.Verification
bun typecheck— exit 0bun test test/session/checkpoint-main-slice.test.ts— 1 pass / 13 assertions