fix(oauth-callback): clean up socket and server event listeners#1347
Open
walker83 wants to merge 1 commit into
Open
fix(oauth-callback): clean up socket and server event listeners#1347walker83 wants to merge 1 commit into
walker83 wants to merge 1 commit into
Conversation
Two listener leaks fixed: 1. isPortInUse(): socket 'connect' and 'error' listeners were never removed after resolve(). Extract named handlers and call socket.off() in each path. 2. ensureRunning(): server 'error' listener (reject) was registered in the listen promise but never removed. Extract named handler and call server.off() on both success and error paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two listener leaks fixed in
oauth-callback.ts.Leak 1:
isPortInUse()socket listenerssocket.on("connect")andsocket.on("error")were registered with anonymous lambdas that can never be removed. Extract named handlers and callsocket.off()on both paths.Leak 2:
ensureRunning()server error listenerserver!.on("error", reject)registers therejectfunction as a listener but never removes it. Extract a namedonErrorhandler and callserver.off()on both success and error paths.Changes
packages/opencode/src/mcp/oauth-callback.tsChecklist