Skip to content

fix: remove SSRF check from MCP server connections #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JinyuXiang-Mimo wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −11
Open

fix: remove SSRF check from MCP server connections #1327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions packages/opencode/src/mcp/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import { Installation } from "../installation"
import { InstallationVersion } from "../installation/version"
import { withTimeout } from "@/util/timeout"
import { AppFileSystem } from "@mimo-ai/shared/filesystem"
import { assertSafeUrl } from "@/util/ssrf"
import { McpOAuthProvider } from "./oauth-provider"
import { McpOAuthCallback } from "./oauth-callback"
import { McpAuth } from "./auth"
Expand Down Expand Up @@ -288,11 +287,6 @@ export const layer = Layer.effect(
key: string,
mcp: ConfigMCP.Info & { type: "remote" },
) {
yield* Effect.tryPromise({
try: () => assertSafeUrl(mcp.url),
catch: (e) => new Error(e instanceof Error ? e.message : String(e)),
}).pipe(Effect.orDie)

const oauthDisabled = mcp.oauth === false
const oauthConfig = typeof mcp.oauth === "object" ? mcp.oauth : undefined
let authProvider: McpOAuthProvider | undefined
Expand Down Expand Up @@ -751,11 +745,6 @@ export const layer = Layer.effect(
if (mcpConfig.type !== "remote") throw new Error(`MCP server ${mcpName} is not a remote server`)
if (mcpConfig.oauth === false) throw new Error(`MCP server ${mcpName} has OAuth explicitly disabled`)

yield* Effect.tryPromise({
try: () => assertSafeUrl(mcpConfig.url),
catch: (e) => new Error(e instanceof Error ? e.message : String(e)),
}).pipe(Effect.orDie)

// OAuth config is optional - if not provided, we'll use auto-discovery
const oauthConfig = typeof mcpConfig.oauth === "object" ? mcpConfig.oauth : undefined

Expand Down
Loading