Preserve thinking.display field when streaming to display thinking for newer opus models#151
Open
durvia wants to merge 2 commits into
Open
Preserve thinking.display field when streaming to display thinking for newer opus models#151durvia wants to merge 2 commits into
durvia wants to merge 2 commits into
Conversation
Add an optional display field to the Enabled and Adaptive variants of
the Thinking enum so the value survives the deserialize -> serialize
round trip. Previously clewdr silently dropped {"display":"summarized"},
so newer models fell back to encrypted thinking on the /code/v1 surface.
The field uses #[serde(default, skip_serializing_if = "Option::is_none")]
so clients sending a bare {"type":"adaptive"} are unaffected.
The display field only applies to adaptive thinking; the budget-based enabled variant should not accept or emit it. Drop display from Enabled and revert Thinking::new.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional display field to Adaptive variants of the Thinking enum so the value survives the deserialize -> serialize round trip.
Previously clewdr silently dropped
{"display":"summarized"}, so newer models fell back to encrypted thinking on the/code/v1surface.The field uses
#[serde(default, skip_serializing_if = "Option::is_none")]so clients sending a bare{"type":"adaptive"}are unaffected.E2E tested.