Avoid PGRAPH register usage analysis in tracing code #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual tracing code in nv2a-trace should know as little as possible about the GPU.
All decoding and analysis tools should be separate or be integrated from separate code using some interface (like callbacks).
However, the existing code did a diff between PGRAPH register dumps as part of the command processor. This breaks this design goal.
This PR modifies it so the state is only written to disk.
A new tool to compare register dumps can be created later, based on the removed code (or written from scratch).
Similar changes are planned for the texture and surface dumping in the future.