Repository navigation
Conversation
Two prompt/help-text rewrites landed without updating tests/test_waveform_prompt_config.py, so two tests fail on main: - 95744ca changed the batch_advanced note in the default system prompt from "不是Checker失败" to "不是验证失败". - df611a1 renamed "failed checkpoint" to "unhit checkpoint" in the dynamic Bug document help text. Update the three stale assertions to the current wording. No runtime behavior changes.
None of the existing workflows run the test suite, which is how the stale assertions fixed in the previous commit reached main unnoticed. Add a Tests workflow with two jobs: - pytest on Python 3.11 (the minimum in pyproject.toml) and 3.12, installing the package with "pip install -e ." exactly as users do. - node --test for the web UI tests under tests/*.js, which only use Node.js built-in modules. tests/test_mcps.py is excluded: it is a manual script that needs a live MCP server on localhost:5000 and the fastmcp package, which is not a project dependency.
7 of 9 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
None of the existing workflows run the test suite, and
maincurrently has two failing tests intests/test_waveform_prompt_config.py. Both come from intentional wording changes whose assertions were not updated:batch_advancednote in the default system prompt from不是Checker失败to不是验证失败.This PR updates those assertions and adds a Tests workflow so this kind of drift is caught on the PR that introduces it.
Changes
Code
Documentation
Tests
Examples / Tooling
tests/test_waveform_prompt_config.py: three assertions now match the current wording. No runtime behavior changes..github/workflows/test.yml: new workflow on push tomain, pull requests tomain, and manual dispatch.pyteston Python 3.11 (therequires-pythonminimum) and 3.12, installed withpip install -e ..node --test tests/*.jsfor the web UI tests, which only use Node.js built-in modules.tests/test_mcps.pyis excluded. It is a manual script that needs a live MCP server onlocalhost:5000and thefastmcppackage, which is not a project dependency.Open question: the plugin test suites under
plugins/*/testsare not run, since each plugin has its own dependencies. Happy to add them as separate jobs if you want.Testing
The same workflow ran green on my fork: https://github.com/alanhc/UCAgent/actions/runs/37881442905 (1200 passed on 3.11 and 3.12, 4 Node tests passed)
Checklist
CONTRIBUTING.md.LICENSE).